Repository navigation
fix(web): right panel's content slides on close - #19
Open
Claudesaul wants to merge 2 commits into
Open
Claudesaul wants to merge 2 commits into
Claudesaul wants to merge 2 commits into
Conversation
Pinning all of the panel's content kept its tab bar clear of the title bar controls, but left the panel looking empty partway through a close, because the edge wiped away everything on its left side. Only the tab bar stays pinned now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closing the right panel makes it look empty partway through. The closing edge wipes across the content from the left, so the file list is gone while the panel is still half open.
This came in with pingdotgg#26233, which pinned all of the panel's content to keep the tab bar out from under the title bar buttons. Only the tab bar needed that.
Change
Only the tab bar stays pinned now. Everything below it slides out with the panel again, as it did before pingdotgg#26233, and the tabs still stay clear of the buttons. Opening does the reverse. Maximized panels and the narrow-window sheet are unchanged.
Scope and approval
Small fix for an obvious visual regression from pingdotgg#26233: the panel goes blank while it closes.
Verification
vp test run apps/web/src/components/RightPanelTabs.test.tsx(10 passed); web typecheck and lint clean.Recording: a few opens and closes at regular speed, then one close and open zoomed in at quarter speed.
Model: Claude Opus 5.5; harness: T3 Code.