Skip to content

fix(query): removed "slowquery" from Neptune Logging is Disabled - Cloudformation/aws#7700

Merged
cx-andre-pereira merged 5 commits into
masterfrom
fix(query)-Neptune_logging_is_disabled-Cloudformation
Sep 11, 2025
Merged

fix(query): removed "slowquery" from Neptune Logging is Disabled - Cloudformation/aws#7700
cx-andre-pereira merged 5 commits into
masterfrom
fix(query)-Neptune_logging_is_disabled-Cloudformation

Conversation

@cx-andre-pereira

@cx-andre-pereira cx-andre-pereira commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Reason for Proposed Changes

Proposed Changes

  • Altered the query logic to ensure the audit value is mandatory to stop the query from flagging.
  • Added new tests to show slowquery is not enough.
  • Added a new test to the terraform query analog and new sample to its negative test.

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions Bot added query New query feature cloudformation CloudFormation query terraform Terraform query aws PR related with AWS Cloud labels Sep 5, 2025
@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.11

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-andre-pereira cx-andre-pereira marked this pull request as ready for review September 5, 2025 09:42
@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner September 5, 2025 09:42

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-andre-pereira cx-andre-pereira merged commit 81e7b6d into master Sep 11, 2025
28 checks passed
@cx-andre-pereira cx-andre-pereira deleted the fix(query)-Neptune_logging_is_disabled-Cloudformation branch September 11, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws PR related with AWS Cloud cloudformation CloudFormation query query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants