feat(query): implements Neptune_Logging_Is_Disabled--cloudformation/aws

[cx-andre-pereira]

Reason for Proposed Changes

• Currently there is no query equivalent of "Neptune Logging Is Disabled" for CloudFormation.
• This query will implement that functionality by ensuring that resources of type AWS::Neptune::DBCluster contain an EnableCloudwatchLogsExports field that include either one, or both, of the valid keywords that ensure logging is enabled, those being : "audit" and "slowquery" .

Proposed Changes

• Implemented query logic with 2 distinct CxPolicy cases:
  • First to account for lack of or null value of the EnableCloudwatchLogsExports field.
  • Second to flag in case the EnableCloudwatchLogsExports field is defined without any of the 2 valid keywords included within it.

Note: After an initial review, the possibility of improving precision on positive5 test's result was raised. A new commit was pushed that adds a is_null_or_missing_LogsExports function to allow for precise results by pointing to the EnableCloudwatchLogsExports field even when the field is null; previously this would cause the results to point to the "Properties" parent field instead making it harder to pinpoint the cause for the result.

I submit this contribution under the Apache-2.0 license.

[github-actions]

KICS version: v2.1.11

Category Results CRITICAL 0 HIGH 0 MEDIUM 0 LOW 0 INFO 0 TRACE 0 TOTAL 0	Metric Values Files scanned 1 Files parsed 1 Files failed to scan 0 Total executed queries 47 Queries failed to execute 0 Execution time 0

[cx-eduardo-semanas]

LGTM

[cx-eduardo-semanas]

LGTM

[gitguardian]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
4266022	Triggered	Generic Password	4b61495	assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/negative7.yaml	View secret
9419039	Triggered	Username Password	4b61495	assets/queries/cloudFormation/aws/amplify_app_basic_auth_config_password_exposed/test/positive6.json	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}