Skip to content

test(query): tests and typo fix for ELBv2_LB_Access_Log_Disabled--terraform/aws#7674

Merged
cx-artur-ribeiro merged 1 commit into
masterfrom
test(query)_ELBv2_LB_Acess_Log_Disabled
Aug 26, 2025
Merged

test(query): tests and typo fix for ELBv2_LB_Access_Log_Disabled--terraform/aws#7674
cx-artur-ribeiro merged 1 commit into
masterfrom
test(query)_ELBv2_LB_Acess_Log_Disabled

Conversation

@cx-andre-pereira

@cx-andre-pereira cx-andre-pereira commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reason for Proposed Changes

  • The implementation of the ELBv2_LB_Access_Log_Disabled - #7594 query was merged with a single test for the legacy naming "aws_alb" for the "aws_lb" resource.
  • Additionally there was a typo on lines 38 57 and 58 were "enable" should be "enabled" referencing the field of the same name.

Proposed Changes

  • Added the missing tests and fixed the typo.

I submit this contribution under the Apache-2.0 license.

@cx-andre-pereira cx-andre-pereira changed the title new tests and typo fix test(query): tests and typo fix for ELBv2_LB_Access_Log_Disabled--terraform/aws Aug 25, 2025
@github-actions github-actions Bot added query New query feature terraform Terraform query aws PR related with AWS Cloud labels Aug 25, 2025
@github-actions

github-actions Bot commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.11

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@Checkmarx Checkmarx deleted a comment from kicsbot Aug 25, 2025
cx-artur-ribeiro
cx-artur-ribeiro approved these changes Aug 25, 2025
View reviewed changes

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-andre-pereira cx-andre-pereira marked this pull request as ready for review August 25, 2025 16:30
@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner August 25, 2025 16:30
@cx-artur-ribeiro cx-artur-ribeiro merged commit f530a58 into master Aug 26, 2025
30 of 33 checks passed
@cx-artur-ribeiro cx-artur-ribeiro deleted the test(query)_ELBv2_LB_Acess_Log_Disabled branch August 26, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cx-artur-ribeiro cx-artur-ribeiro cx-artur-ribeiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cx-andre-pereira cx-andre-pereira

Labels

aws PR related with AWS Cloud query New query feature terraform Terraform query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cx-andre-pereira @cx-artur-ribeiro