feat(query): implements ELBv2_LB_Access_Log_Disabled--terraform/aws

[cx-andre-pereira]

Reason for Proposed Changes

• This query is based on an identical one already implemented for cloudformation, and is currently missing for terraform/aws.
• It is meant to flag if ELBv2 LBs (aws_lb resources) either lack access_logs completely or if that field does not have enabled set to true. Documentation

Proposed Changes

• Based on the original logic of the query i have implemented it for the new cloud provider/payload format associated.
• The positive tests cover 3 scenarios either the lack of one of the 2 relevant fields (access_logs or access_logs.enabled) or the case of access_logs.enabled being set to a value that is not true

Note: There is a slight change in the query naming compared to the original since , in terraform, ALBs are now referred as aws_lb , the legacy naming scheme was aws_alb but the query name itself references the current naming convention.

I submit this contribution under the Apache-2.0 license.

[cx-artur-ribeiro]

Hey André, other than the change on the descriptionId field on the new query, it looks good to me 😄.

[gitguardian]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
4266022	Triggered	Generic Password	af1e7e3	assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/negative7.yaml	View secret
9419039	Triggered	Username Password	cbc7937	assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/positive5.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[cx-artur-ribeiro]

LGTM