Skip to content

test: unit tests and e2e tests of peerDAS branch#8173

Merged
wemeetagain merged 10 commits into
peerDASfrom
te/fix_req_resp_tests
Aug 11, 2025
Merged

test: unit tests and e2e tests of peerDAS branch#8173
wemeetagain merged 10 commits into
peerDASfrom
te/fix_req_resp_tests

Conversation

@twoeths

@twoeths twoeths commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Motivation

  • fix unit tests and e2e tests of peerDAS branch

Description

  • when sending status, based on its body we set correct version, otherwise peers cannot deserialize the request body
    • at fulu fork transition, update local status cache so that it sends the correct version of status message
  • fix failed unit test as introduced by PR-8116

@twoeths twoeths changed the title fix: fork-aware version when sending status message fix: unit tests and e2e tests Aug 11, 2025
@twoeths twoeths marked this pull request as ready for review August 11, 2025 07:14
@twoeths twoeths requested a review from a team as a code owner August 11, 2025 07:14
@twoeths twoeths changed the title fix: unit tests and e2e tests fix: unit tests and e2e tests of peerDAS branch Aug 11, 2025
Comment thread packages/beacon-node/test/e2e/network/reqresp.test.ts
Comment thread packages/beacon-node/test/mocks/mockedBeaconDb.ts Outdated
Comment thread packages/beacon-node/src/network/reqresp/ReqRespBeaconNode.ts Outdated
Comment thread packages/beacon-node/test/unit/chain/archiveStore/blockArchiver.test.ts Outdated
@codecov

codecov Bot commented Aug 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.23%. Comparing base (5a2cffc) to head (af1ba59).
⚠️ Report is 62 commits behind head on peerDAS.

Additional details and impacted files
@@             Coverage Diff             @@
##           peerDAS    #8173      +/-   ##
===========================================
- Coverage    54.39%   54.23%   -0.16%     
===========================================
  Files          844      843       -1     
  Lines        62755    63358     +603     
  Branches      4755     4791      +36     
===========================================
+ Hits         34133    34362     +229     
- Misses       28546    28920     +374     
  Partials        76       76              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nflaig nflaig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will take care of rebasing this, do not merge it yet

@nflaig nflaig marked this pull request as draft August 11, 2025 14:14
@nflaig nflaig marked this pull request as ready for review August 11, 2025 16:32
@nflaig nflaig changed the title fix: unit tests and e2e tests of peerDAS branch test: unit tests and e2e tests of peerDAS branch Aug 11, 2025
@wemeetagain wemeetagain merged commit ee2a431 into peerDAS Aug 11, 2025
18 of 19 checks passed
@wemeetagain wemeetagain deleted the te/fix_req_resp_tests branch August 11, 2025 17:06
@wemeetagain

Copy link
Copy Markdown
Member

🎉 This PR is included in v1.34.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants