fix: only start sending StatusV2 requests after fulu#8169
Merged
Conversation
nflaig
changed the title
nflaig
changed the title
This was referenced Aug 11, 2025
nflaig
commented
Aug 11, 2025
Comment on lines
+863
to
-876
| earliestAvailableSlot: this._earliestAvailableSlot, | ||
| }; | ||
|
|
||
| if (isForkPostFulu(boundary.fork)) { | ||
| (status as fulu.Status).earliestAvailableSlot = this._earliestAvailableSlot; | ||
| } | ||
|
|
||
| return status; |
Member
Author
There was a problem hiding this comment.
this isn't strictly required anymore if we don't use v2 pre-fulu but there is also no downside to it as suggested in #8173 (comment)
nflaig
commented
Aug 11, 2025
Member
Author
There was a problem hiding this comment.
seemed unused so I deleted the file
wemeetagain
reviewed
Aug 11, 2025
wemeetagain
left a comment
wemeetagain
left a comment
Member
There was a problem hiding this comment.
This looks good. What is needed to move from draft?
Member
Author
was trying to figure out why sim tests failed but it seems good now |
wemeetagain
reviewed
Aug 11, 2025
| peerId, | ||
| ReqRespMethod.BeaconBlocksByRange, | ||
| // Before altair, prioritize V2. After altair only request V2 | ||
| this.config.getForkSeq(this.clock.currentSlot) >= ForkSeq.altair ? [Version.V2] : [(Version.V2, Version.V1)], |
wemeetagain
approved these changes
Aug 11, 2025
This was referenced Aug 11, 2025
Member
|
🎉 This PR is included in v1.34.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason to use or allow StatusV2 pre-fulu and we can't properly handle it right now (see code comments for more details).