Restore smart search rotating text and prompts - #318
Merged
Conversation
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
BigSimmo
marked this pull request as ready for review
July 6, 2026 08:02
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BigSimmo
pushed a commit
that referenced
this pull request
Jul 6, 2026
The phone gap assertion measured medication-home one animation frame after visibility, racing the post-hydration check that hides the smart-search hint/prompt rows (restored in #318) and shrinks the portaled composer from 111px to 61px. CI measured the transient state (bottomGap 110.95 < topGap 134) and failed deterministically; fresh local loads reproduced it 3 in 4 runs. Poll until two consecutive measurements match so the guard asserts the settled layout at both widths. Verified 5/5 passes with --repeat-each=5 against a dev server running with the CI env vars. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015UuyyMMegXxTeEJsyR741t
BigSimmo
added a commit
that referenced
this pull request
Aug 15, 2026
14 tasks
BigSimmo
pushed a commit
that referenced
this pull request
Aug 17, 2026
Two pending outstanding-issues update requests targeted #318: 46750cbf (2026-08-15, from PR #1991) and this PR's own db498cc1 (2026-08-17), which restates and extends the former with the fixes landed here. docs:check-links' mutationConflicts guard correctly refused to pick a winner between two pending mutations on the same row, so queue the explicit cancellation the guard's own error message asks for.
BigSimmo
added a commit
that referenced
this pull request
Aug 17, 2026
7 tasks
BigSimmo
pushed a commit
that referenced
this pull request
Aug 18, 2026
Cancels four pending requests found while diagnosing the docs:check-links CI failure — two were duplicates of already-applied requests (#222, #336, each already closed by a different, more accurate applied request), and two asserted "done" outcomes for work this branch's final state does not actually contain after the fabricated-content revert (#318: lexicon sign-off and loperamide exclusion; #309: filter-density fix). All four are cancelled via immutable cancel requests rather than deleted, per ledger-write discipline.
BigSimmo
pushed a commit
that referenced
this pull request
Aug 18, 2026
Cancels 88868df4-c310-4ac2-9e83-cd3ad7702a1d, another false "done" claim from this branch's original batch (same pattern as #222/#318/#309/#336): #183 asks for a live Sentry production metric alert, blocked on missing credentials and unreachable via a code diff. This branch's actual final diff contains no Sentry or alerting changes. Also resolves a collision with a separate, legitimate concurrent update request on the same row from an unrelated branch.
This was referenced Aug 18, 2026
Merged
BigSimmo
added a commit
that referenced
this pull request
Aug 20, 2026
A new P3 task landed on main after this PR's earlier reconcile: the B4 shadow-extraction Gate F runbook (docs/worker-deploy-runbook.md section 3) has four operator unknowns the repo can't answer -- Railway variable-change restart behaviour, no read path for documents.metadata.shadow_extraction, an unratified 10% timeout rollback threshold, and unverified worker memory headroom. This lands after the main-sync merge that brought it in; the #343/#318 requests queued earlier in this branch are still deliberately left pending for the same reason recorded in the earlier reconcile commit.
BigSimmo
added a commit
that referenced
this pull request
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Searching answer • Try: ....Verification
npm run ensure— local Clinical KB verified at the project-safe URL.npm run test:e2e:chromium -- tests/ui-overlap.spec.ts— 12 passed; directly validates restored desktop prompt placement and phone rotating hint placement.npm run test:e2e:chromium -- tests/ui-tools.spec.ts -g "prescribing mode home top-aligns on phones but centres on tablet"— passed after limiting phone smart hint visibility to Answer mode.npm run verify:cheap— passed; lint emitted 3 existing warnings outside this change and no errors.npm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed — 103 passed.npm run verify:releasebefore release or handoff confidence claims — not run; full release confidence not needed for this scoped UI restore.npm run format:checknpm run eval:retrieval:quality(must stay 23/23) when retrieval, ranking, selection, chunking, or scoring behavior changed — not applicable; UI-only search composer chrome.npm run eval:rag -- --limit 15+npm run eval:quality -- --rag-onlywhen answer generation, the synthesis prompt, or answer post-processing changed — not applicable; UI-only search composer chrome.npm run check:production-readinesswhen clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed — not applicable; UI-only search composer chrome.npm run check:deployment-readinesswhen deployment startup, hosting, or rollout behavior changed — not applicable.Walkthrough
mobile_smart_search_rotating_text_restored.mp4
Mobile smart search rotating text above search bar
Clinical Governance Preflight
Not applicable; this change only restores search composer UI helper text/prompts and does not alter ingestion, retrieval ranking, source rendering, document access, privacy, production env, or clinical output.
Notes
Searching answer • Try: ...appears above the mobile search bar and rotates through prompts.To show artifacts inline, enable in settings.