Restore footer suggestion chips on tablet and desktop only - #317
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Defer focus restoration until after the scope popover unmounts, and use double requestAnimationFrame in dismissable layers so Escape reliably returns focus to the answer options trigger.
Keep the footer chip row (Evidence-based, All sources, mode shortcuts) visible from the sm breakpoint up. Phones still reach the same actions through the integrated + menu without the chip row.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
BigSimmo
marked this pull request as ready for review
July 6, 2026 06:16
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverses the phone-only part of the footer chip removal from #303. Footer suggestion chips (Evidence-based, All sources, mode shortcuts) are visible again from the
smbreakpoint up, while phones continue to use the integrated + menu without a chip row.Changes
master-search-header.tsxshowFooterSearchChips = usesFooterChipLayout && !usesPhoneSearchLayoutintegratedChipRowonModeActionPopupto match when chips are shownui-toolscoverage: phones still expect zero visible chips; tablet/desktop expect chips presentVerification
npm run typecheck— passnpm run verify:cheap— pass (1094 tests)Notes
Mobile scope/actions remain reachable via the Open answer options menu; desktop/tablet users get the chip shortcuts back.