Restore desktop smart search suggestions - #314
Merged
Merged
Conversation
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
BigSimmo
marked this pull request as ready for review
July 6, 2026 05:10
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BigSimmo
enabled auto-merge
July 6, 2026 05:17
BigSimmo
added a commit
that referenced
this pull request
Aug 13, 2026
… queue text (#1890) * docs(issues): retire 22 non-actionable ledger rows and correct the #231 queue text A yield review of all 114 open rows against current main. The queue had become roughly 60 tasks and 50 notes; this removes the notes and fixes two places where the ledger was actively misdirecting. The correction that matters most: the recommended-queue entry for #231, the top clinical P1, told every session to "measure and fix the fast-route budget / generation timeout" — an approach #231's own detail records as tested and rejected, because the decisive 40-second probe completed generation in 25.272s with route_deadline_exceeded=false and still failed quality. The session-start hook prints the queue, not the row, so the refuted text was the text agents read. Closed 22 rows: - #304 was already done on main (commit d182844 refreshed the ranking snapshot; generatedAt is 0 days old, not 2026-07-20), yet sat in the queue advertising a freshness fuse that is not armed. - #241 #244 #272 #294 #300 #257 were standing cautions whose own text says "no action". Each one's knowledge now lives in the code it protects, so closing the row loses nothing. - #196-#200 are five steps of the disaster-recovery checklist that is canonical in docs/operator-backlog.md, with no trigger until a restore. - #86 #188 were index rows over children that are individually findable. - #250 #253 #254 were superseded; #250 and #253 say so themselves. - #156 #301 #152 #236 #260 merged into #168, #292 and #169 respectively — each pair or group was one problem recorded two to four times. Demoted 20 rows with a stated reason (premature ops for a single-user prototype, upstream-blocked, measurement-gated, or design-system adoption competing with an open clinical P1). The Pri cell is unchanged because the writer has no --pri flag — which is now #313. Added three rows for mechanism gaps this sweep exposed: rows outliving their own completion (#312), the missing --pri flag (#313), and the queue being able to contradict the row it cites with no guard (#314). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU * docs(ledger): record the ledger yield review handoff Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU * Keep recovery work visible and pin forced colors --------- Co-authored-by: Claude <noreply@anthropic.com>
BigSimmo
pushed a commit
that referenced
this pull request
Aug 13, 2026
…l cannot misdirect The recommended-queue entry for #231, the top clinical P1, told every session to "measure and fix the fast-route budget / generation timeout". #231's own detail records that approach as tested and rejected: the decisive 40-second probe completed generation in 25.272s (27.237s total) with route_deadline_exceeded false and still failed generation quality, so the budget is not the binding cause. The queue and the row had drifted, and the queue is the copy that gets read — .claude/hooks/issues-surface.sh prints it at every session start and scripts/issues-report.mjs serves it to /issues, while the corrected row detail is only seen by someone who opens the file. Re-correcting the cell was tried and cannot land. The ledger inbox has no request type that reaches the queue's Outcome cell, and check:ledger-write-discipline rejects a direct canonical edit, so the correction is unlandable by construction — verified by committing it and watching the gate refuse. SKIP_LEDGER_WRITE_GUARD only bypasses the pre-push hook, not the CI check, so that route pushes but can never merge. So the duplication is removed instead of re-synced, which is what #314 argued for: both consumers now take each queue row's prose from the cited row's own Detail cell. The queue keeps order, acuity, capability, when and estimate — the metadata that exists nowhere else. A composite ID(s) row has no single row to speak for it and keeps its own text. This fixes the whole class, not just #231: no future edit to a row's detail can leave the surfaced text behind, because there is no longer a second copy. The hook needed two passes over the file. The queue table is printed BEFORE "## Open items", so the obvious single forward pass reads every queue row while the lookup is still empty and silently falls back to the stale cell — which it did, on the first attempt, and looked like a working change. tests/issues-report.test.ts pins both halves and was mutation-tested: reverting the derivation fails it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Walkthrough
smart_search_desktop_suggestions_demo_trimmed.mp4
Desktop smart search suggestions after click
Verification
npm run verify:cheapnpm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changednpm run verify:releasebefore release or handoff confidence claims — not run; UI-specific gate passed and release confidence was not requested.npm run format:check— not run; changed files were covered by lint/typecheck and Playwright.npm run eval:retrieval:quality(must stay 23/23) when retrieval, ranking, selection, chunking, or scoring behavior changed — not applicable; UI-only change.npm run eval:rag -- --limit 15+npm run eval:quality -- --rag-onlywhen answer generation, the synthesis prompt, or answer post-processing changed — not applicable; UI-only change.npm run check:production-readinesswhen clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed — not applicable; UI-only change.npm run check:deployment-readinesswhen deployment startup, hosting, or rollout behavior changed — not applicable.Clinical Governance Preflight
Not applicable; this change only restores desktop search suggestion UI and does not touch ingestion, answer generation, ranking, source rendering, document access, privacy, production env, or clinical output.
Notes
Suggestedrow appears above the smart search bar and clicking a suggested chip populates the input.To show artifacts inline, enable in settings.