feat(search): interpret natural language within smart catalogue modes - #2482
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_39d73e3e-1552-495b-b38d-56e4a716c8c6) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fede4029f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #14602 (success). That run's conclusion is an aggregate and did not exercise Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c0690071-2f72-42df-a28a-000ba83b4ba9) |
…-landed-verify Resolve ui-smoke conflict by taking main's containment/rAF asserts from #2471; bring in main package and differentials updates.
…n Smart default-lane assert
…els in Smart assert
…r Smart NL default
153b48b to
f6ae2a7
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d014282a-a0b6-4c3d-9efc-b43bb0850c6f) |
ef296ea to
f6ae2a7
Compare
Summary
Verification
npm run verify:pr-localnpm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changednpm run verify:releasebefore release or handoff confidence claimsnpm run eval:retrieval:quality(must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changednpm run eval:rag -- --limit 15+npm run eval:quality -- --rag-onlynpm run check:production-readinessnpm run check:deployment-readinessAdditional exact-tree evidence:
transport. Final-head commit5dd00a1e63a722d8b0a8d194706e79a2cfecde7brestores both contracts; 42/42 focused unit/DOM tests and four representative previously failing production-browser journeys pass locally.Risk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
origin/mainatd29f70eff898d9da5b343d2c8b6d260970b127b9was merged normally. Auto-merge remains off.Note
Medium Risk
Changes deterministic catalogue ranking and composer routing across seven clinical reference modes; behaviour is test-pinned and provider-free, but result ordering for natural-language queries may shift in production.
Overview
Smart natural-language input no longer routes to Clinical Ask. Enter in the seven catalogue modes always navigates to that mode’s ordinary results surface with the same query in the URL and composer; the shared composer drops
submitSmartSearch, server-gated “Get Smart answer” affordances, andclinicalAskAvailable-driven Smart UI.Provider-free interpretation replaces answer routing.
smart-search-intentis reworked aroundinterpretSmartSearchand per-mode alias rules: natural-language phrases get low-weight vocabulary expansions for deterministic ranking only, while compact codes and embedded identifiers stay literal. Rankers, APIs, mode pages, therapy search, and universal search opt in viainterpretNaturalLanguage/ expansion forwarding; UI copy shifts to “Smart search · catalogue results.”Governance and tests match the split. Clinical governance, search-chrome, and handover docs state that
CLINICAL_ASK_ENABLEDdoes not control Smart search. Playwright and unit tests assert zero/api/clinical-ask/streamcalls for NL queries and pin representative ranked results per mode.Reviewed by Cursor Bugbot for commit f6ae2a7. Configure here.