Skip to content

feat(differentials): surface map and related actions - #2471

Merged
BigSimmo merged 16 commits into
mainfrom
codex/differential-detail-actions
Aug 31, 2026
Merged

feat(differentials): surface map and related actions#2471
BigSimmo merged 16 commits into
mainfrom
codex/differential-detail-actions

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the redundant Differentials > Diagnosis > current-record breadcrumb from diagnosis detail pages while retaining the contextual back navigation.
  • Add an elevated phone-only Explore diagnosis panel that keeps Map and Related visible, with live counts, touch targets, focus treatment, and the existing URL-backed tab behavior.
  • Extend the focused responsive journey and refresh the generated design-system adoption manifest.

Verification

  • npm run verify:pr-local
    • Verification not run for this bare PR publication request.
  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
    • Full UI gate not run for this bare PR publication request.
  • npm run verify:release before release or handoff confidence claims
    • Release gate not run; no release-confidence claim is made.
  • Focused production Chromium journey: npm run test:e2e -- tests/ui-tools.spec.ts --project=chromium --grep "diagnosis detail actions stay tappable and tabs stay single-line" — 1 passed, covering 320/768/1024 px, keyboard activation, overflow, reduced motion, and forced colors.
  • npm run check:design-system-contract — passed for 1,083 production files; adoption checked for 55 components and 84 roots; design-sync checked for 55 components and 7 guidelines.
  • Targeted Prettier check and git diff --check passed before publication.
  • Visual inspection completed at 390 px and 1440 px. Physical iPhone Safari/VoiceOver was not run.

Risk and rollout

  • Risk: Low. This changes diagnosis-detail navigation presentation and focused UI coverage; diagnosis data, clinical wording, section content, and routing destinations are unchanged.
  • Rollback: Revert commit edf16bde9fd1acf7d0c832a82cb24fbe3444365d.
  • Provider or production effects: None.
  • RAG impact: none; no retrieval, ranking, citation, source-rendering, or answer-generation code changed.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use; this contract is unchanged.
  • No patient-identifiable document workflow was introduced or expanded.
  • Supabase target remains unchanged; no Supabase files or configuration were touched.
  • Service-role keys and private document access remain server-only; those paths were not changed.
  • Demo/synthetic content separation is unchanged.
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative and unchanged.
  • Deployment classification/TGA SaMD impact: no clinical decision-support behavior or clinical content changed.

Notes

  • The branch was published 13 commits behind current main; inspection showed no overlap between those commits and the three changed files. GitHub is the requested integration and verification surface.
  • Auto-merge is not enabled.

Co-Authored-By: Codex Fable 5 noreply@anthropic.com


Note

Low Risk
Presentation-only navigation and layout tweaks on diagnosis detail and answer status rows; clinical content, routing destinations, and retrieval logic are unchanged.

Overview
On diagnosis differential detail, the redundant three-level breadcrumb is removed from PageHeader (back navigation in the in-page header remains). A new phone-only Explore diagnosis panel surfaces Map and Related with section detail text, touch-friendly buttons, and the same URL-backed tab switching as the existing tab strip.

In the answer surface, Source-only and stale-evidence controls get self-start so they align at the top of the compact status row instead of stretching with mismatched touch-target heights.

E2E updates: account-provider height checks tolerate Chromium sub-pixel rounding (≥47.99px); review-due status-row geometry asserts containment in one row rather than equal Y alignment; ui-tools coverage adds breadcrumb absence, discovery actions, keyboard activation, overflow, reduced motion, and forced colors. The design-system adoption manifest lists ui-tools as proof for Breadcrumb.

Reviewed by Cursor Bugbot for commit 2ff124a. Configure here.

Co-Authored-By: Codex Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 04e5d219-ef25-4fb5-b09d-c93ab1f2daaa


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Aug 31, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T01:43:19.762279Z edf16bd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cursor

cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_40c61455-9462-4b65-949d-8da79130660e)

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UI (1)main-side: the same job also failed on the latest completed main CI run.
  • PR requiredmain-side: the same job also failed on the latest completed main CI run.

Compared with main CI run #14585 (failure).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

@cursor

cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_fb6d60d6-b6c3-4e55-b785-c9b9118ac147)

@BigSimmo
BigSimmo enabled auto-merge (squash) August 31, 2026 03:02
@BigSimmo
BigSimmo disabled auto-merge August 31, 2026 03:02
@BigSimmo
BigSimmo enabled auto-merge (squash) August 31, 2026 03:03
@cursor

cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_2d6d5d69-0a28-4a10-8883-db6e754da15c)

@cursor

cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_ebbe9aaf-7c6f-41d6-b523-20354e005f9a)

@cursor

cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_6400b4bd-95c5-42e3-87b2-428ecb44e53f)

…us row

The review-due/source-only containment check read boundingBox() immediately
after setViewportSize, racing Chromium's reflow and intermittently reporting
the review-due toggle ~10px short of its settled position (seen at the 768px
breakpoint). Two rAF round-trips let layout finish before measuring.
@BigSimmo
BigSimmo merged commit 8b2371d into main Aug 31, 2026
29 checks passed
@BigSimmo
BigSimmo deleted the codex/differential-detail-actions branch August 31, 2026 08:06
BigSimmo added a commit that referenced this pull request Aug 31, 2026
Resolve conflicts: keep answer UI colour fixes from this PR; take main's ui-smoke.spec.ts (containment asserts from #2471).
BigSimmo added a commit that referenced this pull request Aug 31, 2026
…-landed-verify

Resolve ui-smoke conflict by taking main's containment/rAF asserts from #2471; bring in main package and differentials updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants