feat(differentials): surface map and related actions - #2471
Conversation
Co-Authored-By: Codex Fable 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_40c61455-9462-4b65-949d-8da79130660e) |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #14585 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_fb6d60d6-b6c3-4e55-b785-c9b9118ac147) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2d6d5d69-0a28-4a10-8883-db6e754da15c) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ebbe9aaf-7c6f-41d6-b523-20354e005f9a) |
…tail-actions-local # Conflicts: # tests/ui-smoke.spec.ts
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6400b4bd-95c5-42e3-87b2-428ecb44e53f) |
…us row The review-due/source-only containment check read boundingBox() immediately after setViewportSize, racing Chromium's reflow and intermittently reporting the review-due toggle ~10px short of its settled position (seen at the 768px breakpoint). Two rAF round-trips let layout finish before measuring.
Resolve conflicts: keep answer UI colour fixes from this PR; take main's ui-smoke.spec.ts (containment asserts from #2471).
…-landed-verify Resolve ui-smoke conflict by taking main's containment/rAF asserts from #2471; bring in main package and differentials updates.
Summary
Verification
npm run verify:pr-localnpm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changednpm run verify:releasebefore release or handoff confidence claimsnpm run test:e2e -- tests/ui-tools.spec.ts --project=chromium --grep "diagnosis detail actions stay tappable and tabs stay single-line"— 1 passed, covering 320/768/1024 px, keyboard activation, overflow, reduced motion, and forced colors.npm run check:design-system-contract— passed for 1,083 production files; adoption checked for 55 components and 84 roots; design-sync checked for 55 components and 7 guidelines.git diff --checkpassed before publication.Risk and rollout
edf16bde9fd1acf7d0c832a82cb24fbe3444365d.Clinical Governance Preflight
Notes
main; inspection showed no overlap between those commits and the three changed files. GitHub is the requested integration and verification surface.Co-Authored-By: Codex Fable 5 noreply@anthropic.com
Note
Low Risk
Presentation-only navigation and layout tweaks on diagnosis detail and answer status rows; clinical content, routing destinations, and retrieval logic are unchanged.
Overview
On diagnosis differential detail, the redundant three-level breadcrumb is removed from
PageHeader(back navigation in the in-page header remains). A new phone-only Explore diagnosis panel surfaces Map and Related with section detail text, touch-friendly buttons, and the same URL-backed tab switching as the existing tab strip.In the answer surface, Source-only and stale-evidence controls get
self-startso they align at the top of the compact status row instead of stretching with mismatched touch-target heights.E2E updates: account-provider height checks tolerate Chromium sub-pixel rounding (
≥47.99px); review-due status-row geometry asserts containment in one row rather than equal Y alignment; ui-tools coverage adds breadcrumb absence, discovery actions, keyboard activation, overflow, reduced motion, and forced colors. The design-system adoption manifest lists ui-tools as proof for Breadcrumb.Reviewed by Cursor Bugbot for commit 2ff124a. Configure here.