Skip to content

test(tools): repair the three assertions the tools mockup spec had stale on main #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 5 commits into from
Aug 18, 2026
Merged

test(tools): repair the three assertions the tools mockup spec had stale on main #2115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdbe9bc
test(tools): repair the three assertions the tools mockup spec had st…
BigSimmo Aug 18, 2026
d553b2c
Merge branch 'main' into claude/advisory-tools-spec-repair
BigSimmo Aug 18, 2026
5664a4f
Merge branch 'main' into claude/advisory-tools-spec-repair
BigSimmo Aug 18, 2026
12c3123
chore(ledger): record Run PR sweep review for PR #2115
claude Aug 18, 2026
fbe365a
Merge branch 'main' into claude/advisory-tools-spec-repair
BigSimmo Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ords/9c83ebb18e9d5bf0c5a2f2840eccad03527562a9d96d800d1cdf6b970eaa126a.record.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
| 2026-08-18 | claude/advisory-tools-spec-repair (PR #2115) | 5664a4f6a861060693a8c0611ce5d8bfba487fe7 | Run PR sweep: CI fix + threads + drift | Synced behind branch to origin/main via GitHub update-branch (clean fast-mergeable, no conflicts); no code changes pushed. Pre-sync head d553b2c4 had PR required failing on Unit coverage; post-sync head 5664a4f6 reproduced the same Unit coverage failure (all 671 test files / 7173 tests pass; job fails on an unhandled post-teardown ReferenceError: document is not defined from an uncleared window.setTimeout in src/components/caring-contacts/mockups/caring-contact-shell-frame.tsx:92, triggered while tests/caring-contact-product-redesign.dom.test.tsx runs) -- confirmed unrelated to this PR's 6-line diff in tests/ui-tools-search-mode-mockup.spec.ts, left unfixed as out-of-scope and flagged for a human. 0 unresolved review threads at both heads, none to action. | GitHub-hosted CI only (no local reproduction attempted): Static PR checks pass, Safety and config checks pass, Production UI critical pass, PR policy/PR mergeability pass, Gitleaks/Semgrep/GitGuardian pass, Advisory UI pass (non-required); Unit coverage fails (pre-existing, diff-unrelated); PR required aggregate still failing as a result. No provider-backed checks run. |
12 changes: 6 additions & 6 deletions tests/ui-tools-search-mode-mockup.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ test.describe("Perfected Tools results mode mockup @mockup", () => {
const mockup = await gotoMockup(page, 1440);

await expect(mockup.getByRole("heading", { level: 1, name: "Compare" })).toBeVisible();
await expect(mockup.getByText("1 tool", { exact: true })).toBeVisible();
await expect(mockup.getByText("2 tools", { exact: true })).toBeVisible();
await expect(mockup.getByRole("heading", { level: 2, name: "Differentials" }).first()).toBeVisible();
const selectedResult = mockup.getByRole("article").filter({ hasText: "Differentials" });
await expect(selectedResult).toHaveAttribute("data-selected", "true");
Expand All @@ -39,7 +39,7 @@ test.describe("Perfected Tools results mode mockup @mockup", () => {
await expect(mockup.getByText("Dose converter")).toHaveCount(0);

const categoryRail = mockup.getByRole("radiogroup", { name: "Tool category" });
const allToolsFilter = categoryRail.getByRole("radio", { name: "All tools (1)" });
const allToolsFilter = categoryRail.getByRole("radio", { name: "All tools (2)" });
await allToolsFilter.focus();
await page.keyboard.press("ArrowRight");
await expect(categoryRail.getByRole("radio", { name: "Assess (1)" })).toHaveAttribute("aria-checked", "true");
Expand Down Expand Up @@ -195,23 +195,23 @@ test.describe("Perfected Tools results mode mockup @mockup", () => {
await trigger.click();
const filterSheet = page.locator('[data-testid="tools-search-filter-sheet"]:visible');
await expect(filterSheet).toBeVisible();
await expect(filterSheet.getByText("2 showing", { exact: true })).toBeVisible();
await expect(filterSheet.getByText("2 tools", { exact: true })).toBeVisible();
await expect(filterSheet.getByRole("radio", { name: /Evidence/ })).toHaveAttribute("aria-disabled", "true");

const treatment = filterSheet.getByRole("radio", { name: /Treat/ });
await treatment.click();
await expect(treatment).toHaveAttribute("aria-checked", "true");
await expect(filterSheet).toBeVisible();
await expect(filterSheet.getByText("2 showing", { exact: true })).toBeVisible();
await filterSheet.getByRole("button", { name: "Done" }).click();
await expect(filterSheet.getByText("2 tools", { exact: true })).toBeVisible();
await filterSheet.getByTestId("tools-search-filter-sheet-done").click();
await expect(filterSheet).toHaveCount(0);
await expect(trigger).toContainText("1");

await trigger.click();
await filterSheet.getByRole("button", { name: "Clear filters" }).click();
await expect(filterSheet).toBeVisible();
await expect(filterSheet.getByRole("radio", { name: /All tools/ })).toHaveAttribute("aria-checked", "true");
await expect(filterSheet.getByText("2 showing", { exact: true })).toBeVisible();
await expect(filterSheet.getByText("2 tools", { exact: true })).toBeVisible();
await expectNoHorizontalOverflow(page);
});

Expand Down
Loading