test(tools): repair the three assertions the tools mockup spec had stale on main - #2115
Conversation
…ale on main `tests/ui-tools-search-mode-mockup.spec.ts` failed on clean `main` with no PR applied — 2 failed | 14 passed — so the non-blocking Advisory UI lane was red for every UI PR in the repo regardless of its diff. Two unrelated changes had moved under it. - The seeded `Compare` query now matches two tools, not one: the Clinical Dictionary (#2096) lists "compare" among its keywords and sits in the evidence area, alongside Differentials in assess. Verified against the catalogue itself rather than assumed — `rankToolRecords("Compare")` returns Clinical Dictionary [reference] and Differentials [assessment]. The desktop count and the `All tools (n)` radio name follow. - The filter sheet reports "<n> tools" since the catalogue toolbars were standardised (#2086); it no longer says "<n> showing". Three assertions. - The sheet's confirm control is labelled from its live summary — "View 2 tools" — and only falls back to "Done" when there is no summary. It is now targeted by the stable `tools-search-filter-sheet-done` test id, so the assertion cannot break again when the result count changes. Every replacement value was read from the running page through a temporary probe (sheet inner text and each radio's accessible name), not inferred. Verified: `16 passed` for the whole spec in the chromium-mockups project. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 52 minutes Limit details: You’ve used all 1 included review currently available under your plan. You completed 102 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #12010 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Records the branch-sync-from-main action taken during the Run PR sweep (head d553b2c -> 5664a4f). Unit coverage remains failing on both heads due to a pre-existing, diff-unrelated issue: an uncleared window.setTimeout in caring-contact-shell-frame.tsx fires after test teardown, unrelated to this PR's tools-mockup-spec diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Summary
Repairs the three assertions in
tests/ui-tools-search-mode-mockup.spec.tsthat were stale onmain.Measured on a clean
origin/mainworktree with no PR applied, the spec reported2 failed | 14 passed. BecauseAdvisory UIis not inpr-required's needs list, it could not block anything — it simply went red on every UI PR in the repo, which is worse than a blocking failure: it trains reviewers to ignore the lane. It was reported against #2095 (a mockup-only change that cannot reach the tools surface) and against #2096, and diagnosing it twice is what prompted this.Two unrelated changes had moved under the spec:
Comparequery now matches two tools, not one. The Clinical Dictionary (feat(dictionary): add the eight-route Dictionary reference mode #2096) listscompareamong its keywords and sits in thereferencearea, alongside Differentials inassessment. Confirmed against the catalogue rather than assumed —rankToolRecords("Compare")returnsClinical Dictionary [reference] | Differentials [assessment]. The desktop count assertion and theAll tools (n)radio name follow from that.View 2 tools— and only falls back toDonewhen there is no summary (result-filter-control.tsx). It is now targeted by the stabletools-search-filter-sheet-donetest id, so this assertion cannot break again when a result count changes.Every replacement value was read from the running page through a temporary probe that dumped the sheet's inner text and each radio's accessible name. Nothing here is inferred from the diff.
Verification
node scripts/run-playwright.mjs --project=chromium-mockups tests/ui-tools-search-mode-mockup.spec.ts—16 passed, against2 failed | 14 passedon the same worktree before the change.npm run ensurefirst, per the repo's browser-work rule; the run used the isolated production Playwright build.Not run, with reason: lint, typecheck and the unit suite. The diff is four assertion lines in one Playwright spec — no source, config or type surface is touched, so none of those gates has a failure path here. CI runs them anyway.
Risk and rollout
Notes