docs(issues): close six verified-delivered Tier 1 design rows and refute the min-h-tap finding

[BigSimmo]

Summary

This started as an attempt to bundle the Tier 1 design defects into the minimum number of implementation PRs. Re-verifying each row against origin/main first found that most of the work was already done and one row was actively wrong, so the deliverable is a ledger correction rather than a code change. Nothing under src/ is touched.

Archived as verified-delivered, each checked against current main rather than taken from the row text:

• #171 — documents filtering. document-search-results.tsx no longer references utilityControls, searchCommandSurfaceConfig or commandScopes, so the scope chips are gone and Sources has left the results bar. Source-type was not absorbed into Document type — per #181 those are complementary axes — it stayed its own axis and now joins the same single panel, counting into activeFilterCount and rendering on the shared applied-filters shelf.
• #172 — Sources relocated and renamed rather than deleted, as its stop rule required: browseLibraryControl renders as Browse all sources with the corpus count, shared across the filter-sheet footer and the zero-result empty state.
• #174 — the decision this row asked for was made in favour of OR-within-group. filterDocumentsBySmartTagFacetIndex partitions the selection by group and breaks on the first hit within a group, so two medications now means "either", not zero.
• #181 — the correction to #171 was applied, so it retires alongside it.
• #273 — both max-[413px]: utilities deleted rather than re-thresholded, per the stop rule; the class no longer appears under src/ (8374c3b).
• #274 — clearServiceQuery() now resets local state and replaces the route without q, with the desktop Clear and the phone sheet's onClearAll pointing at that one path. The ui-tools URL assertion the row asked for landed in the same commit (8374c3b).
• #302 — the three ticker exemptions are one clean line each with their reason text preserved; no escaped line-break artifacts remain.

Corrected in place:

• #293 — finding 1 is refuted. The row asserted that min-h-tap carriers have the floor "overridden to 0", blamed "likely an unlayered component class in globals.css", and treated the six shapes as a live 48px-floor defect. What actually zeroes the min-height is the source itself, deliberately: these sites carry an explicit sm: step-down beside min-h-tap. The two 36px shapes are exact matches — services-navigator-page.tsx:217 (grid min-h-tap min-w-tap … sm:h-9 sm:min-h-0) and :286 (inline-flex min-h-tap min-w-[94px] … sm:h-9 sm:min-h-0); sm:min-h-0 is the computed 0px and sm:h-9 is the rendered 36px. Seven min-h-tap sites carry sm:min-h-0, and inline-flex min-h-tap items-center alone appears with sm:min-h-0 (4), sm:min-h-7 (2), sm:min-h-8 (2), sm:min-h-9 (4), sm:min-h-10 (8) and sm:min-h-12 (1). min-h-tap is a phone floor that desktop deliberately releases, and the audit navigates at the desktop viewport, so it was measuring intended design and reporting it as an overridden floor. Removing those step-downs would pin every desktop control to 48px — a visual regression, not an accessibility improvement, since the phone contract already exceeds both WCAG 2.5.8 AA and 2.5.5 AAA. Finding 2 (the enumeration is non-deterministic on a live-search route) stands unchanged and is the whole remaining task; the revised next step is to run it at a phone viewport, where the floor is unreleased and the measurement is meaningful, on a deterministic surface.

Ledger totals move from 145 open / 156 archived to 138 open / 163 archived. No row ids were deleted, and the queue entries for the archived rows were removed per the "a gap means completed" convention.

Verification

• npm run verify:pr-local

PR-local verification summary:
- completed: check:runtime, check:installed-lock-parity, format:changed, sitemap:check,
  docs:check-index, docs:check-inventory, docs:check-scripts, docs:check-links,
  check:branch-review-ledger, check:outstanding-issues
- failed: (none)
- not reached: (none)

Outstanding-issues guard passed: 301 rows (138 open, 163 archived), unique ids,
next-id=304 above the highest, no merge driver, no ids deleted from base 4587f7890818.

verify:pr-local classified this as recognised low-risk docs scope and skipped lint, typecheck, the unit suite, the RAG fixture scan and the build. UI verification not run: no src/ change — the claims about product behaviour are read against origin/main at 4587f78, not introduced here.

One note on the run: check:installed-lock-parity failed on the first attempt because a local npm run build (used while investigating #293) had mutated node_modules after the trusted post-install stamp. That is the full-tree check from #149 working as intended. Resolved with npm ci --include=dev rather than by re-stamping over the drift, then the gate was re-run clean.

Risk and rollout

• Risk: none to the product. Documentation-only; no src/, schema, workflow or dependency change. The residual risk is editorial — if any "verified delivered" reading is wrong, a row is archived that should be open. Each is cited to a file:line or commit so it can be re-opened from the archive, which is why the rows are archived rather than deleted.
• Rollback: git revert this single commit; the archive rows carry their original type and summary text intact.
• Provider or production effects: None.

Notes

Three Tier 1 rows were deliberately left open because they are not implementation work:

• #281 (two clinical-summary surfaces on the phone document route) — both surfaces still render, and the row's own stop rule says the difference between the two renderings is the decision. It needs a clinical-content judgement, not a layout merge.
• #290 (ui-smoke phone scroll-hide flaky on main) — a root-cause investigation on the base branch, not a bundleable fix.
• #300 — exists precisely so nobody converts the three sites it names; no action by design.

#265 still points at #293 for gate 2 and now resolves to the corrected text, so no edit was needed there.

---

Generated by Claude Code

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 20 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5174e87e-06ba-4a88-87bd-439e80541b6f

📥 Commits

Reviewing files that changed from the base of the PR and between 34a2f9f and dcebcc0.

📒 Files selected for processing (2)

• docs/branch-review-ledger.md
• docs/outstanding-issues.md

---

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[Copilot]

Pull request overview

Updates the repository’s outstanding-issues ledger and branch review ledger to reflect re-verified “delivered” work on main, and corrects a misdiagnosis in issue #293 (the min-h-tap “0px” finding).

Changes:

• Archives several Tier 1 design rows as verified-delivered and records detailed closure evidence in docs/outstanding-issues.md.
• Refutes #293 finding (desktop viewport measured intended sm: step-down behavior) and updates next steps toward a deterministic, phone-viewport audit surface.
• Appends review-ledger entries documenting the verification pass(es).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
docs/outstanding-issues.md	Archives/updates multiple ledger rows with current-main verification evidence; refutes the #293 min-h-tap claim and adjusts follow-ups.
docs/branch-review-ledger.md	Adds ledger rows documenting the Tier 1 re-verification and a broader ledger sweep verification run.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.