fix(ci): silence TS5101 baseUrl deprecation for Playwright builds - #1798
Conversation
Next 16.3 typechecks the isolated .next-playwright tsconfig during production UI builds; TypeScript 6 treats baseUrl as deprecated (TS5101) and fails the critical Playwright gate after the npm-production bump.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 8 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
Babysit summary (merged)
|
Unit coverage failed after merging #1798: runners keep baseUrl + ignoreDeprecations, but this branch still asserted root-relative paths. Update the two contract tests to match the kept runner shape.
* fix: honor restoreFocusUnlessMoved on same-mode reselect PR #1790 landed with a force-focus fallback that could override deliberate focus moves after the mode menu closed. Keep only restoreFocusUnlessMoved and cover the no-steal path with a DOM test. Records the #1790 babysit ledger row. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix(ci): drop deprecated baseUrl from isolated Playwright tsconfigs Next 16.3 surfaces TS5101 when the Playwright/Lighthouse run-root tsconfig still injects baseUrl. Resolve @/* with root-relative paths instead so Production UI critical can typecheck again after the main sync. * fix(ci): align Playwright tsconfig contracts with #1798 Unit coverage failed after merging #1798: runners keep baseUrl + ignoreDeprecations, but this branch still asserted root-relative paths. Update the two contract tests to match the kept runner shape. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Summary
.next-playwright/*/tsconfig.jsonduring production UI / Lighthouse builds.baseUrlso@/*still resolves from the repo root; TypeScript 6 reportsTS5101and failsProduction UI critical.ignoreDeprecations: "6.0"to the Playwright and Lighthouse generated tsconfigs and to roottsconfig.json.Test plan
tsc -pagainst a generated playwright-style tsconfig withignoreDeprecationssucceeds locallyProduction UI critical/ related build path green on this tipRisk
Low: silences a known TypeScript 6 deprecation for an intentional temporary
baseUrlin isolated build roots. No product behaviour change.RAG impact: no retrieval behaviour change — CI/tsconfig only.