Skip to content

fix(ci): silence TS5101 baseUrl deprecation for Playwright builds - #1798

Merged
cursor[bot] merged 1 commit into
mainfrom
cursor/playwright-ts-ignore-deprecations-b40c
Aug 10, 2026
Merged

fix(ci): silence TS5101 baseUrl deprecation for Playwright builds#1798
cursor[bot] merged 1 commit into
mainfrom
cursor/playwright-ts-ignore-deprecations-b40c

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Next 16.3 (landed via chore(deps): bump the npm-production group with 5 updates #1793) typechecks the isolated .next-playwright/*/tsconfig.json during production UI / Lighthouse builds.
  • That generated config sets baseUrl so @/* still resolves from the repo root; TypeScript 6 reports TS5101 and fails Production UI critical.
  • Add ignoreDeprecations: "6.0" to the Playwright and Lighthouse generated tsconfigs and to root tsconfig.json.

Test plan

Risk

Low: silences a known TypeScript 6 deprecation for an intentional temporary baseUrl in isolated build roots. No product behaviour change.

RAG impact: no retrieval behaviour change — CI/tsconfig only.

Open in Web Open in Cursor 

Next 16.3 typechecks the isolated .next-playwright tsconfig during
production UI builds; TypeScript 6 treats baseUrl as deprecated (TS5101)
and fails the critical Playwright gate after the npm-production bump.
@supabase

supabase Bot commented Aug 10, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 8 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8651936-ce96-49cf-8054-063ccca9ca14

📥 Commits

Reviewing files that changed from the base of the PR and between c163f3e and 0c041c6.

📒 Files selected for processing (3)
  • scripts/run-lighthouse-budget.mjs
  • scripts/run-playwright.mjs
  • tsconfig.json

Comment @coderabbitai help to get the list of available commands.

@cursor
cursor Bot merged commit ee4e478 into main Aug 10, 2026
27 checks passed
@cursor
cursor Bot deleted the cursor/playwright-ts-ignore-deprecations-b40c branch August 10, 2026 10:51
@cursor

cursor Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Babysit summary (merged)

  • Tip at merge: 0c041c6aeab69aa315907ead275734ea250936c6
  • Sync/merge-tree: clean vs main
  • Blocked by: Next 16.3 + TS6 TS5101 on Playwright/Lighthouse isolated baseUrl tsconfigs (broke Production UI critical after chore(deps): bump the npm-production group with 5 updates #1793)
  • Fixed: ignoreDeprecations: "6.0" in generated Playwright/Lighthouse tsconfigs and root tsconfig.json
  • Required CI: green; squash-merged as ee4e4789328f476068e8b35d59e5d9c853d94ed5
  • Residual risks: temporary silence until @/* paths migrate off baseUrl
  • Merge: completed — unblocks UI-gated open PRs

cursor Bot pushed a commit that referenced this pull request Aug 10, 2026
cursor Bot pushed a commit that referenced this pull request Aug 10, 2026
cursor Bot pushed a commit that referenced this pull request Aug 10, 2026
cursor Bot pushed a commit that referenced this pull request Aug 10, 2026
Unit coverage failed after merging #1798: runners keep baseUrl +
ignoreDeprecations, but this branch still asserted root-relative paths.
Update the two contract tests to match the kept runner shape.
cursor Bot pushed a commit that referenced this pull request Aug 10, 2026
* fix: honor restoreFocusUnlessMoved on same-mode reselect

PR #1790 landed with a force-focus fallback that could override deliberate
focus moves after the mode menu closed. Keep only restoreFocusUnlessMoved
and cover the no-steal path with a DOM test. Records the #1790 babysit
ledger row.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* fix(ci): drop deprecated baseUrl from isolated Playwright tsconfigs

Next 16.3 surfaces TS5101 when the Playwright/Lighthouse run-root
tsconfig still injects baseUrl. Resolve @/* with root-relative paths
instead so Production UI critical can typecheck again after the main sync.

* fix(ci): align Playwright tsconfig contracts with #1798

Unit coverage failed after merging #1798: runners keep baseUrl +
ignoreDeprecations, but this branch still asserted root-relative paths.
Update the two contract tests to match the kept runner shape.

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants