fix same-mode focus restore not stealing deliberate focus - #1792
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 46 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
…-date mergeability
…-date mergeability
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #9583 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Next 16.3 surfaces TS5101 when the Playwright/Lighthouse run-root tsconfig still injects baseUrl. Resolve @/* with root-relative paths instead so Production UI critical can typecheck again after the main sync.
Unit coverage failed after merging #1798: runners keep baseUrl + ignoreDeprecations, but this branch still asserted root-relative paths. Update the two contract tests to match the kept runner shape.
Babysit summary (merged)
|
Summary
restoreFocusUnlessMoved.Why
CodeRabbit flagged that PR #1790's same-mode focus fix could override deliberate focus moves after the mode menu closed. That correction raced auto-merge and did not land in the squash, so this PR lands it on
main.Areas touched
MasterSearchHeadersame-mode focus restore pathVerification
Risk and compatibility
RAG impact: no retrieval behaviour change — focus restore and DOM test only; submission routing, retrieval, ranking, and answer generation are unchanged.