Skip to content

docs(design-system): add the 7 August handover - #1671

Merged
BigSimmo merged 4 commits into
mainfrom
claude/ds-handover
Aug 7, 2026
Merged

docs(design-system): add the 7 August handover#1671
BigSimmo merged 4 commits into
mainfrom
claude/ds-handover

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

Docs only. Adds docs/design-system/HANDOVER-2026-08-07.md and links it from the design-system README as the cold-start entry point.

A fresh session picking this work up currently has to re-derive state that was already measured, and several items in the inherited backlog are provably wrong — establishing that consumed most of the previous session. This file exists so that does not happen twice.

It carries:

  • Measured state, with the command to regenerate every figure: 53 registered / 29 adopted / 24 unadopted · 13 open defect rows · 7 blocking gates, 6 partial, 2 planned · 6 prohibitions with no gate · 0 committed baselines.
  • What landed 7 Aug (fix(design-system): correct three false gate/ledger claims; retire the left/right knob #1655, feat(answer): adopt AnswerCard on the live answer surface; resolve #207 vs #227 #1658, feat(tokens): name the letterspacing scale and ratchet the arbitrary family #1663, refactor(tokens): migrate production letterspacing onto the named scale #1669), including the #207-vs-#227 clinical decision, both sides of it, and why it resolved the way it did — so it is not re-litigated by someone reading only one side.
  • Six measured corrections to the older backlog. The two most expensive: --shadow-focus is not dead (a *.tsx-only grep says it is; the live consumer is .chat-composer-shell-delta:focus-within in globals.css, and it is the forbidden companion ring, so removing it is a visible focus-state change), and check:type-scale / check:icon-scale already ship as hard-zero gates — only the ESLint rules are absent, so the open gap is step selection, not arbitrary sizes.
  • The ordered plan, split into finishing the kit (A1–A6) and updating the live design (B1–B4).
  • The baseline hold as the highest-leverage decision, and why Linux/ubuntu-24.04 provenance cannot be produced on Windows ({platform} in snapshotPathTemplate).
  • Scope discipline — do not build the 43 outlined P1/P2 components; that is the "documentation describes a system 2.8× the usable one" failure the audit named.
  • Repo gotchas that cost the previous session: the stale local main ref (111 commits), the twelve codex/v2-* branches that read as "ahead" while being 14–28k lines behind, lying background-task exit codes, verify:pr-local failing closed on lock parity, and unreliable Chromium under contention.
  • Verification recipes and a ready-to-paste prompt for the next session.

Ledger registration is deliberately left to /issues capture rather than hand-written rows into docs/outstanding-issues.md — ids are allocated read-modify-write and hand-edits have collided before (#156).

Verification

  • npm run docs:check-links — exit 0
  • npm run docs:check-index — exit 0
  • npm run docs:check-inventory — exit 0
  • npm run format applied

No source, test, or config file is touched, so no behavioural gate applies.

RAG impact: no retrieval behaviour change — documentation only. No file under src/lib/rag/**, clinical-search, retrieval-selection, ranking-config, answer-ranking, the eval harness, or the golden fixture is modified.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added a design-system handover guide covering current adoption metrics, completed work, backlog corrections, implementation plans, visual-baseline constraints, and verification steps.
    • Updated the design-system README with a link to the new handover guide for easier project onboarding.

A fresh session picking this work up cold currently has to re-derive state that
was already measured, and several items in the inherited backlog are provably
wrong — the previous session spent most of itself establishing that.

Adds docs/design-system/HANDOVER-2026-08-07.md and links it from the document
set README as the cold-start entry point.

Carries:
- measured state (53 registered / 29 adopted / 24 unadopted; 13 open defect
  rows; 7 blocking gates, 6 partial, 2 planned; 6 ungated prohibitions; 0
  committed baselines), with the command to regenerate every figure
- what landed 7 Aug (#1655, #1658, #1663, #1669) including the #207-vs-#227
  clinical decision and why it went the way it did
- six measured corrections to the older backlog, each of which would otherwise
  send the next session down a wrong path — notably that `--shadow-focus` is NOT
  dead (a *.tsx-only grep says it is; the live consumer is in globals.css), and
  that check:type-scale/check:icon-scale already ship as hard-zero gates
- the ordered plan, split into finishing the kit and updating the live design
- the baseline hold as the decision that unblocks the most, and why Linux
  provenance cannot be produced on Windows
- scope discipline: do not build the 43 outlined P1/P2 components
- the repo gotchas that cost the previous session (stale local main ref, the
  twelve superseded codex/v2-* branches that read as "ahead", lying background
  exit codes, verify:pr-local failing closed on lock parity, contended Chromium)
- verification recipes and a ready-to-use prompt for the next session

Ledger registration is deliberately left to `/issues capture` rather than
hand-written rows: ids are allocated read-modify-write and hand-edits have
collided before (`#156`).

docs:check-links, docs:check-index, docs:check-inventory all exit 0.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@supabase

supabase Bot commented Aug 7, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 57 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 65e6e4b2-c99f-43bb-883e-71f485834bea

📥 Commits

Reviewing files that changed from the base of the PR and between fa52381 and 7d73579.

📒 Files selected for processing (1)
  • docs/design-system/HANDOVER-2026-08-07.md
📝 Walkthrough

Walkthrough

Added a design-system handover document with measured adoption data, corrected backlog assumptions, ordered implementation tracks, repository constraints, verification commands, and next-session instructions. Linked the document from the design-system README.

Changes

Design-system handover

Layer / File(s) Summary
Measured state and implementation plan
docs/design-system/HANDOVER-2026-08-07.md, docs/design-system/README.md
The handover records adoption metrics, landed work, backlog corrections, and the ordered Track A and Track B plan. The README links to the handover document.
Baseline constraints and scope rules
docs/design-system/HANDOVER-2026-08-07.md
The document defines visual-baseline constraints, scope rules, and repository operating notes.
Verification and next-session procedure
docs/design-system/HANDOVER-2026-08-07.md
The document adds verification recipes and next-session instructions for ref validation, Track A1 execution, failure handling, and issue-ledger registration.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change and names the 7 August handover.
Description check ✅ Passed The description explains the documentation scope, key contents, verification results, and why behavioral gates do not apply.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/ds-handover

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/design-system/HANDOVER-2026-08-07.md`:
- Around line 3-6: Update both fresh-session cold-start instructions in the
handover document to require reading AGENTS.md before this handover, preserving
AGENTS.md as the highest-priority source of truth. Apply the same ordering to
the additional referenced instruction.
- Around line 241-243: Update the pre-push recipe around the format and commit
commands to remove git add -A. Instruct users to review git status and git diff,
then stage only explicitly reviewed paths before committing, or omit the commit
step; preserve the subsequent typecheck, lint, and test commands.
🪄 Autofix

✅ Autofix completed


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cf6cf19d-b340-43fe-be8c-d4edc52c442d

📥 Commits

Reviewing files that changed from the base of the PR and between a7e3b40 and fa52381.

📒 Files selected for processing (2)
  • docs/design-system/HANDOVER-2026-08-07.md
  • docs/design-system/README.md

Comment thread docs/design-system/HANDOVER-2026-08-07.md Outdated
Comment thread docs/design-system/HANDOVER-2026-08-07.md
@BigSimmo
BigSimmo enabled auto-merge (squash) August 7, 2026 09:47
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Fixes Applied Successfully

Fixed 1 file(s) based on 2 unresolved review comments.

Files modified:

  • docs/design-system/HANDOVER-2026-08-07.md

Commit: e7937860ff81ad487a2219e5930825d5f2c889e3

The changes have been pushed to the claude/ds-handover branch.

Time taken: 4m 3s

coderabbitai Bot and others added 2 commits August 7, 2026 09:53
Fixed 1 file(s) based on 2 unresolved review comments.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
@BigSimmo
BigSimmo merged commit 38e5a43 into main Aug 7, 2026
22 checks passed
@BigSimmo
BigSimmo deleted the claude/ds-handover branch August 7, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant