issues: log this session's own reviews and the content-verification lesson - #1511
Conversation
…esson Two gaps: work was done and not recorded. - docs/branch-review-ledger.md had no row for claude/root-dir-coverage-gate-v2 (#1458), claude/pre-commit-fail-open (#1494) or claude/ledger-relanding (#1508). AGENTS.md requires one per reviewed branch; appended retrospectively with the merged heads. - #154 records why three separate "did it land" checks returned false answers this session: title greps (reworded concurrently), id greps (ids reallocated in parallel branches), and PR state fields (squash merges, and a MERGED PR whose content had not reached the fetched ref). Resolve the blob and grep for distinctive prose instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 25 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Temporarily closing to preserve the serialized merge queue while #1510 finishes its final exact-head UI shard. This PR will be reviewed and reopened next. |
Summary
Ledger-only. Closes out work that was done but never recorded — the same failure mode the rest of this session's rows exist to prevent.
Three missing review-ledger rows.
docs/branch-review-ledger.mdhad no record ofclaude/root-dir-coverage-gate-v2(docs: close stale hook and script-count records #1458),claude/pre-commit-fail-open(fix(hooks): fail open when the inventory script is absent from the worktree #1494) orclaude/ledger-relanding(issues: re-land the three session findings PR #1490 lost when it was closed #1508). AGENTS.md requires a row per reviewed branch. Appended withnpm run ledger:appendagainst each merged head; the two deleted branches are recorded by their pre-merge head with the squash commit named in the outcome.#154— row ids are not stable identifiers for "did my change land". Three separate checks returned false answers this session, in both directions:main's#149/#150were unrelated rows that took those ids during a parallel renumber, because ids are allocated read-modify-write against a marker and two branches can pick the same number.MERGEDfor a PR whose head was not an ancestor ofmain(normal for squash), and separately a PR readMERGEDwhile its content had not reached the ref that had been fetched.git show <ref>:<path>mangles under MSYS, so grepping its empty output returns 0 and reads as absence.What works is resolving the blob (
git ls-tree→git cat-file -p) and grepping for distinctive prose. The cost of not doing that was concrete: issues: capture the unreadable-CI token, at-risk worktree work, and the unpushed hook fix #1490 was believed landed, was closed unmerged, and took the only record of four preservation snapshots with it — reconstructed as Add guard against new duplicate migration stems #152.Verification
npm run check:outstanding-issues—152 rows (44 open, 108 archived), unique ids, next-id=155 above the highest, no ids deleted from base 68e973a4efd2npm run check:branch-review-ledger—275 live table records + 1206 archived, ledger merge active, six cells each, no conflict markers, mojibake, heading records, or duplicatesnpm run docs:check-links—1415 repo path references resolveRows written with
ledger:append, never hand-authored. Only the two ledger files are touched.🤖 Generated with Claude Code