Skip to content

issues: log this session's own reviews and the content-verification lesson - #1511

Merged
BigSimmo merged 1 commit into
mainfrom
claude/ledger-session-close
Jul 31, 2026
Merged

issues: log this session's own reviews and the content-verification lesson#1511
BigSimmo merged 1 commit into
mainfrom
claude/ledger-session-close

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

Ledger-only. Closes out work that was done but never recorded — the same failure mode the rest of this session's rows exist to prevent.

  • Three missing review-ledger rows. docs/branch-review-ledger.md had no record of claude/root-dir-coverage-gate-v2 (docs: close stale hook and script-count records #1458), claude/pre-commit-fail-open (fix(hooks): fail open when the inventory script is absent from the worktree #1494) or claude/ledger-relanding (issues: re-land the three session findings PR #1490 lost when it was closed #1508). AGENTS.md requires a row per reviewed branch. Appended with npm run ledger:append against each merged head; the two deleted branches are recorded by their pre-merge head with the squash commit named in the outcome.

  • #154 — row ids are not stable identifiers for "did my change land". Three separate checks returned false answers this session, in both directions:

    • Grepping row titles said rows were missing that were present — a concurrent session had reworded them.
    • Grepping row ids said rows were present that were absent — main's #149/#150 were unrelated rows that took those ids during a parallel renumber, because ids are allocated read-modify-write against a marker and two branches can pick the same number.
    • PR state said MERGED for a PR whose head was not an ancestor of main (normal for squash), and separately a PR read MERGED while its content had not reached the ref that had been fetched.
    • A fourth variant, already tracked separately: git show <ref>:<path> mangles under MSYS, so grepping its empty output returns 0 and reads as absence.

    What works is resolving the blob (git ls-treegit cat-file -p) and grepping for distinctive prose. The cost of not doing that was concrete: issues: capture the unreadable-CI token, at-risk worktree work, and the unpushed hook fix #1490 was believed landed, was closed unmerged, and took the only record of four preservation snapshots with it — reconstructed as Add guard against new duplicate migration stems #152.

Verification

  • npm run check:outstanding-issues152 rows (44 open, 108 archived), unique ids, next-id=155 above the highest, no ids deleted from base 68e973a4efd2
  • npm run check:branch-review-ledger275 live table records + 1206 archived, ledger merge active, six cells each, no conflict markers, mojibake, heading records, or duplicates
  • npm run docs:check-links1415 repo path references resolve
  • Prettier — clean

Rows written with ledger:append, never hand-authored. Only the two ledger files are touched.

🤖 Generated with Claude Code

…esson

Two gaps: work was done and not recorded.

- docs/branch-review-ledger.md had no row for claude/root-dir-coverage-gate-v2
  (#1458), claude/pre-commit-fail-open (#1494) or claude/ledger-relanding
  (#1508). AGENTS.md requires one per reviewed branch; appended retrospectively
  with the merged heads.
- #154 records why three separate "did it land" checks returned false answers
  this session: title greps (reworded concurrently), id greps (ids reallocated
  in parallel branches), and PR state fields (squash merges, and a MERGED PR
  whose content had not reached the fetched ref). Resolve the blob and grep for
  distinctive prose instead.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@supabase

supabase Bot commented Jul 31, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 25 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2ef2fd8f-0dee-44bf-a7f0-a127cb682ad6

📥 Commits

Reviewing files that changed from the base of the PR and between 68e973a and b6556d6.

📒 Files selected for processing (2)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@BigSimmo

Copy link
Copy Markdown
Owner Author

Temporarily closing to preserve the serialized merge queue while #1510 finishes its final exact-head UI shard. This PR will be reviewed and reopened next.

@BigSimmo BigSimmo closed this Jul 31, 2026
@BigSimmo
BigSimmo merged commit 46c2c1e into main Jul 31, 2026
23 checks passed
@BigSimmo
BigSimmo deleted the claude/ledger-session-close branch July 31, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant