issues: re-land the three session findings PR #1490 lost when it was closed - #1508
Conversation
…closed PR #1490 was closed unmerged, so none of its content reached main. Confirmed by content rather than id: main's #149 and #150 are unrelated rows (installed-lock parity and CodeRabbit rate limits) that happened to take those ids, so an id-presence check reported them as landed when they were not. - #151 corrects the earlier claim that CI is unreadable. The PAT lacks Checks: read but has Actions: read, so workflow runs are queryable; the endpoint that looked authoritative returns an empty result rather than an error, which is what made it read as a hard wall. - #152 re-lands the at-risk worktree inventory together with the four preservation snapshots taken on 2026-07-31, which existed in no other record. - #153 archives the pre-commit fail-open as resolved by PR #1494. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 46 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
…esson (#1511) Two gaps: work was done and not recorded. - docs/branch-review-ledger.md had no row for claude/root-dir-coverage-gate-v2 (#1458), claude/pre-commit-fail-open (#1494) or claude/ledger-relanding (#1508). AGENTS.md requires one per reviewed branch; appended retrospectively with the merged heads. - #154 records why three separate "did it land" checks returned false answers this session: title greps (reworded concurrently), id greps (ids reallocated in parallel branches), and PR state fields (squash merges, and a MERGED PR whose content had not reached the fetched ref). Resolve the blob and grep for distinctive prose instead. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Summary
Ledger-only. PR #1490 was closed unmerged, so none of its content reached
main. These three findings existed nowhere durable and are re-landed here.A note on how that went unnoticed: checking whether the rows had landed by id reported them present. They were not —
main's#149and#150are unrelated rows (check:installed-lock-paritycoverage, and CodeRabbit review-budget exhaustion) that happened to take those ids during a concurrent renumber. Only a content check showed the originals were absent. Ids allocated in parallel branches are not stable identifiers for "did my row land".#151(new, P3) — corrects an incorrect claim I made repeatedly during the session: that CI could not be read at all. The PAT lacks Checks: read but has Actions: read, sogh api "repos/BigSimmo/Database/actions/runs?head_sha=<sha>"answers the question. What made this look like a hard wall is thatGET /commits/:sha/statussucceeds and returnstotal: 0— this repo reports through Actions, not legacy statuses — so the permission gap presented as an absence of checks. The cost was real: two PRs were armed for auto-merge rather than merged, on the belief their hosted verdict was unknowable. For the record, issues: capture the unreadable-CI token, at-risk worktree work, and the unpushed hook fix #1490's head wasCI/PR Policy/PR mergeability/SAST/Secret Scanallcompleted/success.#152(new, P2) — the at-risk worktree inventory plus the four preservation snapshots (748ef018f,5dbd9f965,b7eae51a4,d949859c3). Those commits exist on their branches but nothing recorded that they exist or why; that record was the unique content of the closed issues: capture the unreadable-CI token, at-risk worktree work, and the unpushed hook fix #1490. The largest is +395/−200 across 19 files including.github/workflows/ci.yml.#153(archived) — the pre-commit hook aborting commits in worktrees that lack the sync script, resolved by PR fix(hooks): fail open when the inventory script is absent from the worktree #1494.Verification
npm run check:outstanding-issues—151 rows (45 open, 106 archived), unique ids, next-id=154 above the highest, no ids deleted from base c531bc6fe66anpm run docs:check-links—1414 repo path references resolve#151/#152in Open items,#153in Resolved / archive. My first attempt anchored on#148, which lives in the archive table, and the guard caught the misplacement as a cell-count error — worth knowing that the guard catches this.No file other than
docs/outstanding-issues.mdis touched.🤖 Generated with Claude Code