Sheets: preserve responsive height caps

[BigSimmo]

Summary

Preserve caller-provided mobile and small-screen max-height caps independently in the shared Sheet component.

Sources reviewed

#1338, #1356, #1357, and production navigation/calculator portions of #1331.

Retained

The current-main-compatible responsive height-precedence fix and its DOM contract.

Rejected

Broken overlay imports, stale sidebar/routes, wholesale focus/inert rewrites, production calculator removal, and stale navigation architecture.

Verification

• git diff --check
• focused sheet DOM Vitest: 6/6 passed
• npm run verify:cheap: passed; 412 test files, 4199 tests passed, 3 skipped
• npm run ensure: app started at http://localhost:3434
• npm run verify:ui: 320 passed, 3 failed outside the changed files

UI failures

• ui-route-coverage.spec.ts: Specifier map selection did not update aria-pressed
• ui-smoke.spec.ts: document search hit counter was not found
• ui-smoke.spec.ts: clinical summary disclosure did not collapse

Risk / follow-up

The focused Sheet behavior and broad local unit gate are green, but this remains draft until the three UI failures are classified or the required UI gate passes. No physical Safari/PWA proof was run.

Summary by CodeRabbit

• Bug Fixes
  • Improved sheet panel sizing logic so caller-supplied height constraints (max-h-* and sm:max-h-*, including ! variants) reliably override default limits across screen sizes.
• Tests
  • Added a test ensuring custom responsive height caps remain present, and fallback default height caps are not applied when overrides are provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4ca64c75-8118-49a3-ad64-60fdee5d20ee

📥 Commits

Reviewing files that changed from the base of the PR and between 7df15df and 4e7e38c.

📒 Files selected for processing (1)

• src/components/ui/sheet.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• src/components/ui/sheet.tsx

---

📝 Walkthrough

Walkthrough

Sheet separately detects caller-provided base and sm: max-height utilities, omits matching default caps, and verifies both behaviors with a DOM test.

Changes

Sheet height-cap overrides

Layer / File(s)	Summary
Height-cap detection and application src/components/ui/sheet.tsx, tests/sheet.dom.test.tsx	Sheet tokenizes contentClassName, detects base and sm: max-h-* utilities, conditionally omits matching defaults, and tests both override cases.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• BigSimmo/Database#1356: Updates the same Sheet height-cap detection behavior and adds related DOM assertions.
• BigSimmo/Database#732: Modifies the same Sheet vertical sizing and max-height behavior.

Suggested labels: codex

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: preserving responsive height caps in the Sheet component.
Description check	✅ Passed	The description includes Summary, Sources reviewed, Verification, and UI failures/follow-up, which satisfies the template well enough.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[github-actions]

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

• Production UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #6379 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.