Organize dirty work: cursor/pr1196-coalesce-main-4711 - #1331
Conversation
Delete dying search/embedding inflight map entries when the last waiter disconnects, and ceil fractional PDF render dimensions before the safe-integer pixel budget check.
Close without merge: tip is stale/conflicting and the remediation family already landed on main; live coalesce/PDF fixes stay in #1212.
Append ledger row after a clean merge of origin/main into the coalesce-poison fix branch; no product conflict resolution needed.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 25 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (60)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a501a2c9b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export { CalculatorsDirectoryGridMockup } from "./directory-grid-mockup"; | ||
| export { CalculatorsGuidedFlowMockup } from "./guided-flow-mockup"; | ||
| export { CalculatorsPopupSheetMockup } from "./popup-sheet-mockup"; | ||
| export { CalculatorsSearchPageMockup } from "./search-page-mockup"; |
There was a problem hiding this comment.
When a user opens an existing /calculators bookmark or link, this demotion to mockup-only exports accompanies deletion of src/app/(search-app)/calculators/page.tsx and the Tools catalogue record, so the production feature now returns 404 and disappears from navigation. Keep the production route/catalogue entry or provide a compatible replacement rather than silently removing the newly shipped calculator workflow.
Useful? React with 👍 / 👎.
| | 2026-07-25 | PR supersede #1186 / `cursor/pr1186-audit-remediation-c94c` | `a38e83860510a4229d5658960657cd7448aff278` | Clean main-based port of intentional #1186 audit fixes | SUPERSEDE #1186 (do not merge old PR). Ported intentional 16-file delta onto current main; dropped conflicted checkpoint tree and placeholder skills. Fixed eval single results binding; async run-heavy so lock heartbeat fires; branch:cleanup dry-run default + argv-safe deletes; skill-create interface YAML. Close #1186. | Focused Vitest tooling+lock 6/6; check:skills 33; prettier on touched files; no provider/live eval runs. | | ||
| | 2026-07-25 | PR #1200 / `cursor/typography-audit-fixes-1c1e` | pending-push | CORRECTION: remove exact-duplicate ledger row | Removed a merge-union exact duplicate of the `cursor/ledger-066-067-519b` / `f04392a40` READY row (kept the earlier copy). No product change. | `npm run check:branch-review-ledger` | | ||
| | 2026-07-25 | PR #1190 / `remediate-dark-mode-audit` | `00eca49b9b0d7e5fbfa5703a15e9e930963984a6` | Cursor review+Bugbot+prlanded+debug (fresh pass, same HEAD) | DO NOT MERGE; NOT LANDED (OPEN, mergeable=CONFLICTING/DIRTY, 468 behind / 2 ahead). Reconfirmed P0: conflict resolution deleted `trustGatedAnswerForClinicalNotes` (0 hits on head; main L584/632/659/1075) — Clinical Notes consumes ungated answer. P1: `src/app/api/answer/route.ts:6` imports nonexistent `@/lib/rag` (tsc TS2307; stream correctly uses `@/lib/rag/rag`). P1: merge-tree conflicts on answer/upload/evidence-panels + 10 paths; literal `<<<<<<<` in docs audit plan; migration timestamp collision risk vs main. Intentional dark-mode delta is only commit `363672602` (~10 files). Salvage: `cursor/pr1190-dark-mode-salvage-f453` cherry-picks that commit onto current main, restores unused-manifest-import cleanup, keeps clinical gate. Close #1190 after salvage lands. | Bugbot; `git grep` gate/import/markers; merge-tree; `tsc` TS2307 proof; gh pr view/checks (PR policy fail). Salvage: tsc clean; visual-evidence+overlay tests 13/13; eslint on changed files. No provider/UI matrix. | | ||
| | 2026-07-25 | `cursor/ledger-066-067-519b` | f04392a408eceee14215c15169cbd6b70ac2041c | Close stale ledger #066/#067 (+ drop resolved #030/#075 from queue) | READY. #066 proven on main via #1174; #067 already fixed in #1191 in-process preflight. Docs-only ledger sync; no code change. | Local proof: `git show`/`log` for #1174/#1191; preflight test already in-process on main; ledger integrity asserts. No providers. | |
There was a problem hiding this comment.
This ledger hunk removes previously appended review and handoff records for branches such as PR #1200 and PR #1190, which erases the state used to prevent duplicate reviews and retain prior blockers. Restore the removed rows and record any correction or superseding outcome only as a new appended row, as required by the repository's append-only ledger contract.
AGENTS.md reference: AGENTS.md:L146-L146
Useful? React with 👍 / 👎.
| onClick={() => move(-1)} | ||
| disabled={activeIndex === 0} | ||
| className="inline-flex min-h-tap items-center gap-2 rounded-lg border border-[color:var(--border-strong)] bg-[color:var(--surface)] px-4 text-sm font-bold text-[color:var(--text-muted)] disabled:cursor-not-allowed disabled:border-[color:var(--border)] disabled:bg-[color:var(--surface-inset)]" | ||
| className="inline-flex min-h-tap items-center gap-2 rounded-lg border border-[color:var(--border-strong)] bg-[color:var(--surface)] px-4 text-sm font-bold text-[color:var(--text-muted)] disabled:opacity-40" |
There was a problem hiding this comment.
On WebKit, after the formulation step navigation changes from disabled to enabled, the restored disabled:opacity-40/disabled:opacity-45 utilities can leave stale reduced opacity on an enabled button, producing the low-contrast state previously fixed by b91b460 and documented by matrix run 4012. Retain the explicit disabled surface/text styling and the focused native-disabled/opacity regression coverage instead of reintroducing opacity-based state.
Useful? React with 👍 / 👎.
| background: linear-gradient( | ||
| 180deg, | ||
| transparent 0%, | ||
| color-mix(in srgb, var(--background) 72%, transparent) 42%, | ||
| color-mix(in srgb, var(--background) 94%, transparent) 72%, | ||
| var(--background) 100% | ||
| ); |
There was a problem hiding this comment.
On submitted phone search views, changing the edge-to-edge dock from a solid surface to this transparent gradient, while also restoring its backdrop layer and removing the phone paint tests, reintroduces multiple translucent layers over scrolling content and the compositing defect fixed immediately before this commit. Keep the single bounded phone header/footer surface and retain a narrower guard rather than deleting the existing static and Playwright coverage.
AGENTS.md reference: AGENTS.md:L221-L221
Useful? React with 👍 / 👎.
1 participant
This PR organizes dirty work currently grouped under branch cursor/pr1196-coalesce-main-4711.