Add lava tip hologram when scoopable obsidian forms#2915
Merged
tastybento merged 3 commits intoApr 6, 2026
Conversation
When obsidian forms from lava/water interaction and is solitary (could be scooped), a TextDisplay hologram is shown above the block for a configurable duration. The hologram uses MiniMessage locale text from the OBSIDIAN_SCOOPING section. - Add obsidian-scooping-lava-tip-duration setting (default 30s, 0 disables) - Add lavaTip locale entry in en-US.yml - Add BlockFormEvent handler in ObsidianScoopingListener - Add hologram placement logic (above, sides, below preference) - Schedule hologram removal after configured duration - Add comprehensive tests for new functionality Agent-Logs-Url: https://github.com/BentoBoxWorld/BentoBox/sessions/9e56595b-e55a-4b06-a281-117940895a89 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Address code review feedback to avoid calling BentoBox.getInstance() multiple times within handleObsidianForm method. Agent-Logs-Url: https://github.com/BentoBoxWorld/BentoBox/sessions/9e56595b-e55a-4b06-a281-117940895a89 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add hologram notification for obsidian recovery
Add lava tip hologram when scoopable obsidian forms
Apr 6, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New players often don't realize obsidian can be scooped back into lava with a bucket. This adds a temporary TextDisplay hologram above newly formed obsidian when it's solitary and scoopable.
Changes
ObsidianScoopingListener— NewBlockFormEventhandler that:TextDisplayhologram at the best available adjacent air/liquid block (prefers above → sides → below)runTaskLaterSettings— Newobsidian-scooping-lava-tip-durationconfig entry (default 30s; ≤0 disables)en-US.yml— NewlavaTipkey underOBSIDIAN_SCOOPING:Tests — 8 new test cases covering: non-obsidian events, out-of-world, flag disabled, duration disabled, nearby obsidian, successful spawn with scheduler verification, empty locale text, and hologram placement logic.