Skip to content

fix: conversation link button in memory items - #3005

Merged
beastoin merged 2 commits into
BasedHardware:mainfrom
krushnarout:fix/conversation-link-button
Sep 29, 2025
Merged

fix: conversation link button in memory items#3005
beastoin merged 2 commits into
BasedHardware:mainfrom
krushnarout:fix/conversation-link-button

Conversation

@krushnarout

Copy link
Copy Markdown
Member

#2988

Screen.Recording.2025-09-18.at.11.29.39.AM.mov

@beastoin

Copy link
Copy Markdown
Collaborator

Setup precommit please: https://docs.omi.me/doc/developer/AppSetup#9-code-formatting%E2%80%8B

Why do we need this technique? https://github.com/BasedHardware/omi/pull/3005/files#diff-e2d707a3d1d0c58b6b7dc266f73ebff4fba390c293d811e02ad2da93432a568aR226-R254

In the best scenarios, main.dart is the only place that controls how the provider would be created.

Man, learn more and upgrade your skills, please.

@krushnarout

Copy link
Copy Markdown
Member Author

Man, learn more and upgrade your skills, please.

Yes, I'm always learning and improving

@krushnarout

Copy link
Copy Markdown
Member Author

@beastoin I updated the navigation flow to use existing providers from context instead of recreating them inside the route.

Screen.Recording.2025-09-22.at.1.01.38.PM.mov

@aaravgarg

aaravgarg commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

@krushnarout, deprecate the public/private toggle UI of memories as thats irrelevant for a while

@beastoin

Copy link
Copy Markdown
Collaborator

lgtm @krushnarout.

btw @aaravgarg, check the need for toggling the memory before deciding to hide it. also, I don’t really know why I need to see which conversation this memory is linked to, but I trust your taste.

@beastoin
beastoin merged commit 20b36d4 into BasedHardware:main Sep 29, 2025
@krushnarout
krushnarout deleted the fix/conversation-link-button branch September 29, 2025 03:11
@aaravgarg

aaravgarg commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

lgtm @krushnarout.

btw @aaravgarg, check the need for toggling the memory before deciding to hide it. also, I don’t really know why I need to see which conversation this memory is linked to, but I trust your taste.

its for personas which is a dead feature, pls correct me if im wrong here.

2/ it helps coz sometimes it says "Someone wanted golf set for their birthday", you myt wanna go to convo to see which person actually said it. its trivial but nice to have and was easy to implement, hence implemented. thanks btw

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
* fix: conversation link button in memory items

* fix: resolve providers from existing context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants