feat: conversation link button in memory items - #2988
Merged
Conversation
Collaborator
what is this? review your code before opening the PR, or just mark it as draft if it’s not ready. |
Member
Author
@beastoin I mistakenly included changes of a different approach, thank you |
Collaborator
|
lgtm @krushnarout |
beastoin
added a commit
that referenced
this pull request
Sep 18, 2025
Collaborator
|
reverted, pls resolve #3000 my question, did you see the build error ? |
Member
Author
Collaborator
|
sry, it’s a runtime exception. did you try running it and showing the exception during rendering? check your console logs. |
Member
Author
|
before it was working fine #2988 (comment) Screen.Recording.2025-09-13.at.4.21.31.PM.movafter I added the changes from #2988 to the latest Screen.Recording.2025-09-18.at.10.57.36.AM.movfixed in pr #3005 |
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
* feat: conversation link button to memory items * remove unrelated changes
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
…#2988)" (BasedHardware#3000) This reverts commit d6a8cf3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2889
Screen.Recording.2025-09-13.at.4.21.31.PM.mov