Address feedback on ARM heuristic LRO helper implementation and tests#4510
Merged
heaths merged 3 commits intoJun 2, 2026
Conversation
- Revert `state` field from `PollerOptions` (comment #3338002639)
- Remove `new_poller_can_resume_from_state` test (depended on removed field)
- Fix `resource_url` clone: use `initial_request.url().clone()` inside
the closure instead of cloning a captured `resource_url` variable
(comment #3337973698)
- Expand doc comment on `new_poller` to describe each polling mode with
its associated header name (comment #3337968630)
- Handle empty-body (204 No Content) responses by deserialising `{}`
so status falls through to the HTTP status-code check
- Fall back to `resource_url` in the Succeeded arm so synchronous
completions work when there is no prior final_link
- Add six new test cases ported from the Go SDK async/body/loc pollers
(comment #3337983148): no-location async, synchronous completion,
async/body/location failed, body/location 204 No Content
- Run cargo fmt and cargo clippy (comment #4405613982)
Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>
… completion test Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>
heaths
changed the title
heaths
approved these changes
Jun 2, 2026
heaths
left a comment
heaths
left a comment
Member
There was a problem hiding this comment.
This is a terrible way to review changes I requested to a PR.
heaths
deleted the
copilot/wip-address-feedback-on-arm-heuristic-lro-helper-i
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback on #4508. I've created this new PR, which merges into #4508, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.
Original PR: #4508
Triggering reviews:
azure_core::http::poller::resource_manager#4508 (comment)azure_core::http::poller::resource_manager#4508 (comment)azure_core::http::poller::resource_manager#4508 (comment)azure_core::http::poller::resource_manager#4508 (comment)