Add ARM poller helper under `azure_core::http::poller::resource_manager` by Copilot · Pull Request #4508 · Azure/azure-sdk-for-rust

Copilot · 2026-06-01T23:20:53Z

Adds azure_core::http::poller::resource_manager::new_poller(...) for resource manager long-running operations.

The helper selects polling behavior heuristically from azure-asyncoperation, operation-location, location, or the original resource URL fallback. It also resolves relative and absolute poll/final URLs, avoids deserializing a monitor for empty terminal bodies, and returns explicit errors for failed or canceled terminal states.

This change also adds focused mock-based coverage for async, body, operation-location, and location polling paths in sdk/core/azure_core/src/http/poller/resource_manager/tests.rs.

Co-authored-by: Heath Stewart heaths@microsoft.com

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

heaths

Also make sure to format and lint code per instructions.

Copilot · 2026-06-02T01:05:55Z

@heaths I've opened a new pull request, #4510, to work on those changes. Once the pull request is ready, I'll request review from you.

…#4510) Thanks for the feedback on #4508. I've created this new PR, which merges into #4508, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress. Original PR: #4508 Triggering reviews: - #4508 (comment) > @copilot expand on these monikers better, like "async" should mention the `azure-asyncoperation` header. - #4508 (comment) > @copilot since we clone the `initial_request` above as well as its URL, I don't think we need to clone `resource_url` here yet again. Can't we just `initial_request.url().clone()` here? - #4508 (comment) > @copilot make sure we cover all test cases for async, body, and loc directories for `*_test.go` files under https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/azcore/internal/pollers. - #4508 (comment) > @copilot this field shouldn't be necessary. Undo changes related to this `state` field and I'll handle that in a separate PR. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Copilot

Pull request overview

Adds an ARM-specific long-running-operation (LRO) poller helper under azure_core::http::poller::resource_manager, aiming to centralize ARM polling heuristics (async/body/location) behind a single entrypoint and provide mock-based test coverage.

Changes:

Introduces azure_core::http::poller::resource_manager::new_poller(...) implementing ARM header/body heuristics and relative/absolute URL handling.
Adds a new resource_manager module to the public http::poller namespace.
Adds mock HTTP tests covering async, body, and location patterns plus some terminal/failure cases.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
sdk/core/azure_core/src/http/poller/resource_manager/mod.rs	New ARM heuristic poller implementation and link-resolution helpers.
sdk/core/azure_core/src/http/poller/resource_manager/tests.rs	New mock-based tests for common ARM LRO polling patterns.
sdk/core/azure_core/src/http/poller.rs	Exposes the new `resource_manager` module.

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

@copilot also make sure to format and lint changed code. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Copilot · 2026-06-02T02:23:03Z

Also make sure to format and lint code per instructions.

Addressed in d2d0b84. I ran cargo fmt, the targeted new_poller_ tests, and cargo clippy for azure_core.

heaths

"ARM" and "LRO" are not good in customer-facing error messages. Use "resource manager" instead of "ARM" and "poller" or "long-running operation" instead of "LRO" where appropriate i.e., "poller" when referring to the code itself or "long-running operation" when referring to service behavior.

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

heaths

I'll pull down and finish it myself.

heaths · 2026-06-02T02:42:03Z

@copilot update the title and the PR description to match the current implementation. The description should be concise and mention that it resolves #4296.

Copilot · 2026-06-02T02:45:49Z

@copilot update the title and the PR description to match the current implementation. The description should be concise and mention that it resolves #4296.

I can’t edit the PR title directly with the tools available here, but this would match the current implementation:

Title: Add resource manager poller helper under azure_core::http::poller::resource_manager``

Description: Adds azure_core::http::poller::resource_manager::new_poller(...)for resource manager long-running operations, using header/body heuristics to chooseazure-asyncoperation, operation-location, location, or resource polling, with focused mock-based coverage for those paths. Resolves #4296.

Fixed references to "ARM" and "LRO" to be more user-friendly in user-facing errors. Also made sure to always set the `api-version` query parameter which should be universal for all ARM operations.

heaths · 2026-06-10T22:32:59Z

Discussed offline: I'll create an ArmPoller and probably will re-export from within poller but still define in a separate submodule for cleanliness based more on Java's implementation that otherwise took a similar approach for DP pollers for TypeSpec as us. I'll probably just abandon this Frankenbranch and start anew with newly generated azure_resourcemanager_keyvault as well since a lot has changed in the emitter.

Initial plan

2259135

Copilot AI assigned Copilot and heaths Jun 1, 2026

Copilot started work on behalf of heaths June 1, 2026 23:20 View session

Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request

Need heuristic-based LRO helper for ARM crates #4296

Open

Copilot AI and others added 2 commits June 1, 2026 23:38

Add ARM resource manager poller helper

71e5efd

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Refine ARM poller tests and shared constants

1d44578

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add heuristic-based LRO helper for ARM crates~~ Add ARM heuristic LRO helper under azure_core::http::poller::resource_manager Jun 1, 2026

Copilot finished work on behalf of heaths June 1, 2026 23:43

Copilot AI requested a review from heaths June 1, 2026 23:43

heaths requested changes Jun 2, 2026

View reviewed changes

Copilot AI mentioned this pull request Jun 2, 2026

Address feedback on ARM heuristic LRO helper implementation and tests #4510

Merged

heaths requested changes Jun 2, 2026

View reviewed changes

Comment thread sdk/core/azure_core/src/http/poller/resource_manager/mod.rs Outdated

Comment thread sdk/core/azure_core/src/http/poller/resource_manager/mod.rs Outdated

Comment thread sdk/core/azure_core/src/http/poller/resource_manager/tests.rs Outdated

heaths marked this pull request as ready for review June 2, 2026 01:46

heaths requested review from RickWinter and xirzec as code owners June 2, 2026 01:46

Copilot AI review requested due to automatic review settings June 2, 2026 01:46

heaths requested a review from LarryOsterman as a code owner June 2, 2026 01:46

Copilot started work on behalf of heaths June 2, 2026 01:46 View session

Copilot started reviewing on behalf of heaths June 2, 2026 01:47 View session

Address ARM poller review feedback and expand tests

3a8f8d4

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Copilot AI reviewed Jun 2, 2026

View reviewed changes

Avoid monitor allocation for empty ARM poll bodies

a545f9d

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Copilot finished work on behalf of heaths June 2, 2026 01:57

Copilot AI requested a review from heaths June 2, 2026 01:57

Apply suggestions from code review

b139ece

@copilot also make sure to format and lint changed code. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

heaths requested changes Jun 2, 2026

View reviewed changes

Comment thread sdk/core/azure_core/src/http/poller/resource_manager/mod.rs

Comment thread sdk/core/azure_core/src/http/poller/resource_manager/mod.rs

Copilot started work on behalf of heaths June 2, 2026 02:17 View session

Add operation-location poller coverage

d2d0b84

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Copilot finished work on behalf of heaths June 2, 2026 02:23

Copilot AI requested a review from heaths June 2, 2026 02:23

heaths requested changes Jun 2, 2026

View reviewed changes

Comment thread sdk/core/azure_core/src/http/poller/resource_manager/mod.rs

Copilot started work on behalf of heaths June 2, 2026 02:32 View session

Copilot AI and others added 3 commits June 2, 2026 02:35

Handle failed resource manager terminal statuses

994f315

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Refine failed terminal status handling

1718c83

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

Simplify failed terminal status message selection

e3bd066

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>

heaths reviewed Jun 2, 2026

View reviewed changes

Copilot finished work on behalf of heaths June 2, 2026 02:40

Copilot AI requested a review from heaths June 2, 2026 02:40

Copilot started work on behalf of heaths June 2, 2026 02:42 View session

Copilot AI changed the title ~~Add ARM heuristic LRO helper under azure_core::http::poller::resource_manager~~ Add resource manager poller helper under azure_core::http::poller::resource_manager Jun 2, 2026

Copilot finished work on behalf of heaths June 2, 2026 02:46

Several improvements including messaging

93e0a45

Fixed references to "ARM" and "LRO" to be more user-friendly in user-facing errors. Also made sure to always set the `api-version` query parameter which should be universal for all ARM operations.

heaths requested review from antkmsft and jhendrixMSFT June 2, 2026 04:03

heaths changed the title ~~Add resource manager poller helper under azure_core::http::poller::resource_manager~~ Add ARM poller helper under azure_core::http::poller::resource_manager Jun 2, 2026

heaths approved these changes Jun 2, 2026

View reviewed changes

jhendrixMSFT reviewed Jun 2, 2026

View reviewed changes

Comment thread sdk/core/azure_core/src/http/poller/resource_manager/mod.rs

heaths mentioned this pull request Jun 2, 2026

Create branching ARM LRO implementations #4518

Open

Conversation

Copilot AI commented Jun 1, 2026 • edited by heaths Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

heaths left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jun 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jun 2, 2026

Uh oh!

heaths left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

heaths left a comment

Choose a reason for hiding this comment

Uh oh!

heaths commented Jun 2, 2026

Uh oh!

Copilot AI commented Jun 2, 2026

Uh oh!

Uh oh!

heaths commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jun 1, 2026 •

edited by heaths

Loading