Skip to content

Fix Layout Grid bottom sheet Android close button - #239

Merged
dcalhoun merged 2 commits into
masterfrom
bug/fix-layout-grid-android-close-button
Aug 26, 2021
Merged

dcalhoun merged 2 commits into
masterfrom
bug/fix-layout-grid-android-close-button

Conversation

@dcalhoun

@dcalhoun dcalhoun commented Aug 26, 2021 •

Copy link
Copy Markdown
Member

Related PRs

Description

Apply required margin and padding to properly align Android close button in the Layout Grid block bottom sheet. Relates to #238 and WordPress/gutenberg#34332.

How has this been tested?

Performed the following on both Android and iOS.

  1. Open the block editor.
  2. Add a Layout Grid block.
  3. Expected: The X/Cancel button is correct aligned on the left side of the bottom sheet, and not flush with the left side of the screen.

Screenshots

Before After
layout-grid-before-android layout-grid-after-android
layout-grid-before-ios layout-grid-after-ios

Types of changes

Bug fix

Apply required margin and padding to properly align Android close
button in the Layout Grid block bottom sheet.
@dcalhoun dcalhoun added the Bug Something isn't working label Aug 26, 2021
@dcalhoun dcalhoun self-assigned this Aug 26, 2021

@geriux geriux left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it on both iOS and Android 👏

@dcalhoun
dcalhoun merged commit 00dbb96 into master Aug 26, 2021
@dcalhoun
dcalhoun deleted the bug/fix-layout-grid-android-close-button branch August 26, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants