Skip to content

RNmobile: Fix the cancel button on Layout Grid Block - #238

Merged
enejb merged 1 commit into
masterfrom
rnmobile/fix-layout-grid-bottom-sheet
Aug 24, 2021
Merged

enejb merged 1 commit into
masterfrom
rnmobile/fix-layout-grid-bottom-sheet

Conversation

@enejb

@enejb enejb commented Aug 23, 2021 •

Copy link
Copy Markdown
Member

In #34018 we refactored how we apply the padding of the buttons in the navigation header. This Pr add the padding that we missed to add to the layout grid block.

Screenshots:

Before:
Screen Shot 2021-08-23 at 4 29 08 PM

After:
Screen Shot 2021-08-23 at 4 34 04 PM

How has this been tested?

Load the PR on in the mobile app.
Add the layout grid block. Notice that the cancel button has a padding now.

related:
WordPress/gutenberg#34249

In #34018 we refactored how we apply the padding the buttons in the navigation header. This Pr add the padding that we missed to add to the columns grid block.
@enejb enejb added the Bug Something isn't working label Aug 23, 2021
@enejb
enejb requested a review from dcalhoun August 23, 2021 23:40
@enejb enejb self-assigned this Aug 23, 2021

@dcalhoun dcalhoun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified Layout Grid Block Cancel button was aligned as expected. Thank you for addressing this oversight. 🙇🏻

@enejb
enejb merged commit 5821937 into master Aug 24, 2021
@enejb
enejb deleted the rnmobile/fix-layout-grid-bottom-sheet branch August 24, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants