Fix flaky test - #3231
Fix flaky test#3231
Conversation
Fix flaky test if there's a race in the shared pool between parallel test executions.
There was a problem hiding this comment.
🟡 Changes recommended
The FakeTimeProvider assertion will fail deterministically on .NET 8+ until corrected.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request isolates cancellation-token pool tests from the shared process-wide pool to prevent race-related flakiness.
Changes:
- Uses a dedicated pool for reusable-pool tests.
- Exposes the pooled implementation internally for testing.
- The
FakeTimeProviderreuse assertion still needs correction.
File summaries
| File | Summary |
|---|---|
test/Polly.Core.Tests/Utils/CancellationTokenSourcePoolTests.cs |
Uses an isolated pool but contains an incorrect reuse assertion on pooled targets. |
src/Polly.Core/Utils/CancellationTokenSourcePool.Pooled.cs |
Enables internal construction of the pooled implementation for tests. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3231 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 321 321
Lines 7099 7099
Branches 1089 1089
=======================================
Hits 6959 6959
Misses 98 98
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Updated [Microsoft.Extensions.Caching.StackExchangeRedis](https://github.com/dotnet/dotnet) from 10.0.11 to 10.0.12. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Extensions.Caching.StackExchangeRedis's releases](https://github.com/dotnet/dotnet/releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.com/dotnet/dotnet/commits). </details> Updated [Microsoft.Extensions.DependencyInjection](https://github.com/dotnet/dotnet) from 10.0.11 to 10.0.12. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Extensions.DependencyInjection's releases](https://github.com/dotnet/dotnet/releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.com/dotnet/dotnet/commits). </details> Updated [MongoDB.Driver](https://github.com/mongodb/mongo-csharp-driver) from 3.11.2 to 3.12.0. <details> <summary>Release notes</summary> _Sourced from [MongoDB.Driver's releases](https://github.com/mongodb/mongo-csharp-driver/releases)._ ## 3.12.0 This is the general availability release for the 3.12.0 version of the driver. ### The main new features in 3.12.0 include: - [CSHARP-6214](https://jira.mongodb.org/browse/CSHARP-6214): Implement srvAllowedHostsSuffix URI option ### Fixes: - [CSHARP-6223](https://jira.mongodb.org/browse/CSHARP-6223): Fix client-side projection crash on member-init projections The full list of issues resolved in this release is available at [CSHARP JIRA project](https://jira.mongodb.org/issues/?jql=project%20%3D%20CSHARP%20AND%20fixVersion%20%3D%203.12.0%20ORDER%20BY%20key%20ASC). Documentation on the .NET driver can be found [here](https://www.mongodb.com/docs/drivers/csharp/v3.12/). Commits viewable in [compare view](mongodb/mongo-csharp-driver@v3.11.2...v3.12.0). </details> Updated [OpenTelemetry.Exporter.OpenTelemetryProtocol](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.18.0 to 1.19.0. <details> <summary>Release notes</summary> _Sourced from [OpenTelemetry.Exporter.OpenTelemetryProtocol's releases](https://github.com/open-telemetry/opentelemetry-dotnet/releases)._ ## 1.19.0 For highlights and announcements pertaining to this release see: [Release Notes > 1.19.0](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/RELEASENOTES.md#1190). The following changes are from the previous release [1.19.0-rc.1](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.19.0-rc.1). * NuGet: [OpenTelemetry v1.19.0](https://www.nuget.org/packages/OpenTelemetry/1.19.0) * Added Schema URL to internally created `Resource` instances. ([#7726](open-telemetry/opentelemetry-dotnet#7726)) * Reduced allocations when formatting self-diagnostics events with up to three parameters. ([#7730](open-telemetry/opentelemetry-dotnet#7730)) * Added `AlwaysRecordSampler`. ([#7695](open-telemetry/opentelemetry-dotnet#7695)) * Fixed `CircularBufferBuckets` so the first delta histogram insertion after a reset does not result in an unnecessary scale reduction. ([#7749](open-telemetry/opentelemetry-dotnet#7749)) * Improved wildcard source/meter name matching to avoid excessive matching time at runtime. ([#7760](open-telemetry/opentelemetry-dotnet#7760)) * Fixed lazy logger provider builds after a failure from reusing partially initialized provider state. ([#7761](open-telemetry/opentelemetry-dotnet#7761)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0/src/OpenTelemetry/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api v1.19.0](https://www.nuget.org/packages/OpenTelemetry.Api/1.19.0) * Reduced allocations when creating log record attributes from an array. ([#7699](open-telemetry/opentelemetry-dotnet#7699)) * Reduced allocations when setting baggage through the `params` overload. ([#7697](open-telemetry/opentelemetry-dotnet#7697)) * Reduced allocations when constructing `SpanAttributes` from an array. ([#7698](open-telemetry/opentelemetry-dotnet#7698)) * Fixed parsing of an inbound `tracestate` header whose member value trimmed to an empty value that previously threw an `IndexOutOfRangeException` internally and could silently truncate the tracestate. ([#7756](open-telemetry/opentelemetry-dotnet#7756)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0/src/OpenTelemetry.Api/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api.ProviderBuilderExtensions v1.19.0](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions/1.19.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0/src/OpenTelemetry.Api.ProviderBuilderExtensions/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Console v1.19.0](https://www.nuget.org/packages/OpenTelemetry.Exporter.Console/1.19.0) ... (truncated) ## 1.19.0-rc.1 The following changes are from the previous release [1.18.0](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.18.0). * NuGet: [OpenTelemetry v1.19.0-rc.1](https://www.nuget.org/packages/OpenTelemetry/1.19.0-rc.1) * Added Schema URL to internally created `Resource` instances. ([#7726](open-telemetry/opentelemetry-dotnet#7726)) * Reduced allocations when formatting self-diagnostics events with up to three parameters. ([#7730](open-telemetry/opentelemetry-dotnet#7730)) * Added `AlwaysRecordSampler`. ([#7695](open-telemetry/opentelemetry-dotnet#7695)) * Fixed `CircularBufferBuckets` so the first delta histogram insertion after a reset does not result in an unnecessary scale reduction. ([#7749](open-telemetry/opentelemetry-dotnet#7749)) * Improved wildcard source/meter name matching to avoid excessive matching time at runtime. ([#7760](open-telemetry/opentelemetry-dotnet#7760)) * Fixed lazy logger provider builds after a failure from reusing partially initialized provider state. ([#7761](open-telemetry/opentelemetry-dotnet#7761)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0-rc.1/src/OpenTelemetry/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api v1.19.0-rc.1](https://www.nuget.org/packages/OpenTelemetry.Api/1.19.0-rc.1) * Reduced allocations when creating log record attributes from an array. ([#7699](open-telemetry/opentelemetry-dotnet#7699)) * Reduced allocations when setting baggage through the `params` overload. ([#7697](open-telemetry/opentelemetry-dotnet#7697)) * Reduced allocations when constructing `SpanAttributes` from an array. ([#7698](open-telemetry/opentelemetry-dotnet#7698)) * Fixed parsing of an inbound `tracestate` header whose member value trimmed to an empty value that previously threw an `IndexOutOfRangeException` internally and could silently truncate the tracestate. ([#7756](open-telemetry/opentelemetry-dotnet#7756)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0-rc.1/src/OpenTelemetry.Api/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api.ProviderBuilderExtensions v1.19.0-rc.1](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions/1.19.0-rc.1) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0-rc.1/src/OpenTelemetry.Api.ProviderBuilderExtensions/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Console v1.19.0-rc.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Console/1.19.0-rc.1) * Extended key/value list attribute handling to cover additional dictionary shapes (`IEnumerable<KeyValuePair<string, string?>>` and `IDictionary`). These attributes will be serialized as JSON objects. ([#7679](open-telemetry/opentelemetry-dotnet#7679)) ... (truncated) ## 1.19.0-beta.1 The following changes are from the previous release [1.18.0-beta.1](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/coreunstable-1.18.0-beta.1). * NuGet: [OpenTelemetry.Exporter.Prometheus.AspNetCore v1.19.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.AspNetCore/1.19.0-beta.1) * **Breaking Change** The `PrometheusTranslationStrategy` enum was renamed to `PrometheusAspNetCoreTranslationStrategy`. ([#7751](open-telemetry/opentelemetry-dotnet#7751)) * Fixed OpenMetrics `_created` series being emitted for metric points with a default start time. ([#7754](open-telemetry/opentelemetry-dotnet#7754)) * Prometheus text/OpenMetrics escaping of label values, label names and help text is now more efficient. ([#7758](open-telemetry/opentelemetry-dotnet#7758)) * A scrape request whose connection is aborted, or whose `X-Prometheus-Scrape-Timeout-Seconds` deadline elapses, now stops waiting for an in-progress metrics collection instead of continuing to wait for it to finish. The collection itself is not cancelled and continues running in the background. ([#7757](open-telemetry/opentelemetry-dotnet#7757)) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#7785](open-telemetry/opentelemetry-dotnet#7785)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.19.0-beta.1/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Prometheus.HttpListener v1.19.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.HttpListener/1.19.0-beta.1) * **Breaking Change** The `PrometheusTranslationStrategy` enum was renamed to `PrometheusHttpListenerTranslationStrategy`. ([#7751](open-telemetry/opentelemetry-dotnet#7751)) * Fixed OpenMetrics `_created` series being emitted for metric points with a default start time. ([#7754](open-telemetry/opentelemetry-dotnet#7754)) * Prometheus text/OpenMetrics escaping of label values, label names and help text is now more efficient. ([#7758](open-telemetry/opentelemetry-dotnet#7758)) * Added `PrometheusHttpListenerOptions.ScrapeResponseTimeoutMilliseconds` (default `60000`) which bounds how long a scrape request waits for its response. `X-Prometheus-Scrape-Timeout-Seconds` request header values may only shorten this limit. The limit bounds the request's wait only: a metrics collection already running when it is reached is not cancelled and continues running in the background. ([#7757](open-telemetry/opentelemetry-dotnet#7757)) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#7785](open-telemetry/opentelemetry-dotnet#7785)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.19.0-beta.1/src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Shims.OpenTracing v1.19.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Shims.OpenTracing/1.19.0-beta.1) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#7785](open-telemetry/opentelemetry-dotnet#7785)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.19.0-beta.1/src/OpenTelemetry.Shims.OpenTracing/CHANGELOG.md) for details. Commits viewable in [compare view](open-telemetry/opentelemetry-dotnet@core-1.18.0...core-1.19.0). </details> Updated [OpenTelemetry.Extensions.Hosting](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.18.0 to 1.19.0. <details> <summary>Release notes</summary> _Sourced from [OpenTelemetry.Extensions.Hosting's releases](https://github.com/open-telemetry/opentelemetry-dotnet/releases)._ ## 1.19.0 For highlights and announcements pertaining to this release see: [Release Notes > 1.19.0](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/RELEASENOTES.md#1190). The following changes are from the previous release [1.19.0-rc.1](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.19.0-rc.1). * NuGet: [OpenTelemetry v1.19.0](https://www.nuget.org/packages/OpenTelemetry/1.19.0) * Added Schema URL to internally created `Resource` instances. ([#7726](open-telemetry/opentelemetry-dotnet#7726)) * Reduced allocations when formatting self-diagnostics events with up to three parameters. ([#7730](open-telemetry/opentelemetry-dotnet#7730)) * Added `AlwaysRecordSampler`. ([#7695](open-telemetry/opentelemetry-dotnet#7695)) * Fixed `CircularBufferBuckets` so the first delta histogram insertion after a reset does not result in an unnecessary scale reduction. ([#7749](open-telemetry/opentelemetry-dotnet#7749)) * Improved wildcard source/meter name matching to avoid excessive matching time at runtime. ([#7760](open-telemetry/opentelemetry-dotnet#7760)) * Fixed lazy logger provider builds after a failure from reusing partially initialized provider state. ([#7761](open-telemetry/opentelemetry-dotnet#7761)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0/src/OpenTelemetry/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api v1.19.0](https://www.nuget.org/packages/OpenTelemetry.Api/1.19.0) * Reduced allocations when creating log record attributes from an array. ([#7699](open-telemetry/opentelemetry-dotnet#7699)) * Reduced allocations when setting baggage through the `params` overload. ([#7697](open-telemetry/opentelemetry-dotnet#7697)) * Reduced allocations when constructing `SpanAttributes` from an array. ([#7698](open-telemetry/opentelemetry-dotnet#7698)) * Fixed parsing of an inbound `tracestate` header whose member value trimmed to an empty value that previously threw an `IndexOutOfRangeException` internally and could silently truncate the tracestate. ([#7756](open-telemetry/opentelemetry-dotnet#7756)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0/src/OpenTelemetry.Api/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api.ProviderBuilderExtensions v1.19.0](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions/1.19.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0/src/OpenTelemetry.Api.ProviderBuilderExtensions/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Console v1.19.0](https://www.nuget.org/packages/OpenTelemetry.Exporter.Console/1.19.0) ... (truncated) ## 1.19.0-rc.1 The following changes are from the previous release [1.18.0](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.18.0). * NuGet: [OpenTelemetry v1.19.0-rc.1](https://www.nuget.org/packages/OpenTelemetry/1.19.0-rc.1) * Added Schema URL to internally created `Resource` instances. ([#7726](open-telemetry/opentelemetry-dotnet#7726)) * Reduced allocations when formatting self-diagnostics events with up to three parameters. ([#7730](open-telemetry/opentelemetry-dotnet#7730)) * Added `AlwaysRecordSampler`. ([#7695](open-telemetry/opentelemetry-dotnet#7695)) * Fixed `CircularBufferBuckets` so the first delta histogram insertion after a reset does not result in an unnecessary scale reduction. ([#7749](open-telemetry/opentelemetry-dotnet#7749)) * Improved wildcard source/meter name matching to avoid excessive matching time at runtime. ([#7760](open-telemetry/opentelemetry-dotnet#7760)) * Fixed lazy logger provider builds after a failure from reusing partially initialized provider state. ([#7761](open-telemetry/opentelemetry-dotnet#7761)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0-rc.1/src/OpenTelemetry/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api v1.19.0-rc.1](https://www.nuget.org/packages/OpenTelemetry.Api/1.19.0-rc.1) * Reduced allocations when creating log record attributes from an array. ([#7699](open-telemetry/opentelemetry-dotnet#7699)) * Reduced allocations when setting baggage through the `params` overload. ([#7697](open-telemetry/opentelemetry-dotnet#7697)) * Reduced allocations when constructing `SpanAttributes` from an array. ([#7698](open-telemetry/opentelemetry-dotnet#7698)) * Fixed parsing of an inbound `tracestate` header whose member value trimmed to an empty value that previously threw an `IndexOutOfRangeException` internally and could silently truncate the tracestate. ([#7756](open-telemetry/opentelemetry-dotnet#7756)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0-rc.1/src/OpenTelemetry.Api/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api.ProviderBuilderExtensions v1.19.0-rc.1](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions/1.19.0-rc.1) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.19.0-rc.1/src/OpenTelemetry.Api.ProviderBuilderExtensions/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Console v1.19.0-rc.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Console/1.19.0-rc.1) * Extended key/value list attribute handling to cover additional dictionary shapes (`IEnumerable<KeyValuePair<string, string?>>` and `IDictionary`). These attributes will be serialized as JSON objects. ([#7679](open-telemetry/opentelemetry-dotnet#7679)) ... (truncated) ## 1.19.0-beta.1 The following changes are from the previous release [1.18.0-beta.1](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/coreunstable-1.18.0-beta.1). * NuGet: [OpenTelemetry.Exporter.Prometheus.AspNetCore v1.19.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.AspNetCore/1.19.0-beta.1) * **Breaking Change** The `PrometheusTranslationStrategy` enum was renamed to `PrometheusAspNetCoreTranslationStrategy`. ([#7751](open-telemetry/opentelemetry-dotnet#7751)) * Fixed OpenMetrics `_created` series being emitted for metric points with a default start time. ([#7754](open-telemetry/opentelemetry-dotnet#7754)) * Prometheus text/OpenMetrics escaping of label values, label names and help text is now more efficient. ([#7758](open-telemetry/opentelemetry-dotnet#7758)) * A scrape request whose connection is aborted, or whose `X-Prometheus-Scrape-Timeout-Seconds` deadline elapses, now stops waiting for an in-progress metrics collection instead of continuing to wait for it to finish. The collection itself is not cancelled and continues running in the background. ([#7757](open-telemetry/opentelemetry-dotnet#7757)) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#7785](open-telemetry/opentelemetry-dotnet#7785)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.19.0-beta.1/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Prometheus.HttpListener v1.19.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.HttpListener/1.19.0-beta.1) * **Breaking Change** The `PrometheusTranslationStrategy` enum was renamed to `PrometheusHttpListenerTranslationStrategy`. ([#7751](open-telemetry/opentelemetry-dotnet#7751)) * Fixed OpenMetrics `_created` series being emitted for metric points with a default start time. ([#7754](open-telemetry/opentelemetry-dotnet#7754)) * Prometheus text/OpenMetrics escaping of label values, label names and help text is now more efficient. ([#7758](open-telemetry/opentelemetry-dotnet#7758)) * Added `PrometheusHttpListenerOptions.ScrapeResponseTimeoutMilliseconds` (default `60000`) which bounds how long a scrape request waits for its response. `X-Prometheus-Scrape-Timeout-Seconds` request header values may only shorten this limit. The limit bounds the request's wait only: a metrics collection already running when it is reached is not cancelled and continues running in the background. ([#7757](open-telemetry/opentelemetry-dotnet#7757)) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#7785](open-telemetry/opentelemetry-dotnet#7785)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.19.0-beta.1/src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Shims.OpenTracing v1.19.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Shims.OpenTracing/1.19.0-beta.1) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#7785](open-telemetry/opentelemetry-dotnet#7785)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.19.0-beta.1/src/OpenTelemetry.Shims.OpenTracing/CHANGELOG.md) for details. Commits viewable in [compare view](open-telemetry/opentelemetry-dotnet@core-1.18.0...core-1.19.0). </details> Updated [OpenTelemetry.Instrumentation.AspNetCore](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 1.18.0 to 1.19.0. <details> <summary>Release notes</summary> _Sourced from [OpenTelemetry.Instrumentation.AspNetCore's releases](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)._ ## 1.19.0 * NuGet: [OpenTelemetry.Exporter.OneCollector v1.19.0](https://www.nuget.org/packages/OpenTelemetry.Exporter.OneCollector/1.19.0) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#5240](open-telemetry/opentelemetry-dotnet-contrib#5240)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Exporter.OneCollector-1.19.0/src/OpenTelemetry.Exporter.OneCollector/CHANGELOG.md) for details. ## 1.19.0-rc.1 * NuGet: [OpenTelemetry.Instrumentation.Process v1.19.0-rc.1](https://www.nuget.org/packages/OpenTelemetry.Instrumentation.Process/1.19.0-rc.1) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#5240](open-telemetry/opentelemetry-dotnet-contrib#5240)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Instrumentation.Process-1.19.0-rc.1/src/OpenTelemetry.Instrumentation.Process/CHANGELOG.md) for details. ## 1.19.0-beta.1 * NuGet: [OpenTelemetry.Exporter.Geneva v1.19.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Geneva/1.19.0-beta.1) * Fixed OTLP protobuf serialization for nested messages with lengths at or above 16 KiB. ([#5147](open-telemetry/opentelemetry-dotnet-contrib#5147)) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#5240](open-telemetry/opentelemetry-dotnet-contrib#5240)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Exporter.Geneva-1.19.0-beta.1/src/OpenTelemetry.Exporter.Geneva/CHANGELOG.md) for details. ## 1.19.0-alpha.1 * NuGet: [OpenTelemetry.Instrumentation.EventCounters v1.19.0-alpha.1](https://www.nuget.org/packages/OpenTelemetry.Instrumentation.EventCounters/1.19.0-alpha.1) * Updated OpenTelemetry core component version(s) to `1.19.0`. ([#5240](open-telemetry/opentelemetry-dotnet-contrib#5240)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Instrumentation.EventCounters-1.19.0-alpha.1/src/OpenTelemetry.Instrumentation.EventCounters/CHANGELOG.md) for details. ## 1.18.1 * NuGet: [OpenTelemetry.Resources.AWS v1.18.1](https://www.nuget.org/packages/OpenTelemetry.Resources.AWS/1.18.1) * Added `host.image.id` resource attribute to `AWSEC2Detector`, populated from the EC2 instance identity document's `imageId` (AMI ID). ([#5110](open-telemetry/opentelemetry-dotnet-contrib#5110)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Resources.AWS-1.18.1/src/OpenTelemetry.Resources.AWS/CHANGELOG.md) for details. Commits viewable in [compare view](open-telemetry/opentelemetry-dotnet-contrib@Exporter.OneCollector-1.18.0...Exporter.OneCollector-1.19.0). </details> Updated [Polly](https://github.com/App-vNext/Polly) from 8.7.0 to 8.8.0. <details> <summary>Release notes</summary> _Sourced from [Polly's releases](https://github.com/App-vNext/Polly/releases)._ ## 8.8.0 ## Highlights * Add `EnableReloadsWithMonitor()` accepting custom `IOptionsMonitor` by @arashzjahangiri in App-vNext/Polly#3140 * Return null from `FaultGenerator` when no fault is generated by @dualfroz in App-vNext/Polly#3220 ## What's Changed * Update workflow timeout by @martincostello in App-vNext/Polly#3106 * Set `SOURCE_DATE_EPOCH` by @martincostello in App-vNext/Polly#3115 * Use `NUGET_API_KEY` by @martincostello in App-vNext/Polly#3116 * Test refactoring by @martincostello in App-vNext/Polly#3132 * Avoid test flakiness by @martincostello in App-vNext/Polly#3134 * Group github/codeql-action updates by @martincostello in App-vNext/Polly#3147 * Fix wrong word in hedging documentation by @latent-9 in App-vNext/Polly#3191 * OSMF sponsorship notice by @joelhulen in App-vNext/Polly#3194 * Fix XML doc comment on `PipelineExecutedArguments` by @JiuYue0820 in App-vNext/Polly#3201 * Update to xunit v3 by @martincostello in App-vNext/Polly#3131 * .NET 11 preparation by @martincostello in App-vNext/Polly#3225 * Fix flaky test by @martincostello in App-vNext/Polly#3231 ## New Contributors * @arashzjahangiri made their first contribution in App-vNext/Polly#3140 * @latent-9 made their first contribution in App-vNext/Polly#3191 * @JiuYue0820 made their first contribution in App-vNext/Polly#3201 * @dualfroz made their first contribution in App-vNext/Polly#3220 **Full Changelog**: App-vNext/Polly@8.7.0...8.8.0 Commits viewable in [compare view](App-vNext/Polly@8.7.0...8.8.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fix flaky test if there's a race in the shared pool between parallel test executions.