[SDK] Fix incorrect delta histogram scale after circular buffer reset - #7749
Merged
martincostello merged 4 commits intoSep 15, 2026
Merged
martincostello merged 4 commits into
martincostello merged 4 commits into
Conversation
Pull request dashboard statusMerged · refreshed 2026-09-17 06:23 UTC Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7749 +/- ##
==========================================
- Coverage 91.87% 91.86% -0.01%
==========================================
Files 337 337
Lines 18380 18382 +2
==========================================
Hits 16887 16887
- Misses 1493 1495 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
approved these changes
Sep 15, 2026
martincostello
approved these changes
Sep 15, 2026
This was referenced Sep 18, 2026
This was referenced Sep 28, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed
CircularBufferBucketsreset handling so the internal state is cleared correctly.Previously, stale state could cause an unnecessary scale reduction for the first recording in a new delta histogram.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes