Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 65.87% 67.62% +1.75%
==========================================
Files 3 6 +3
Lines 337 451 +114
==========================================
+ Hits 222 305 +83
- Misses 115 146 +31 ☔ View full report in Codecov by Sentry. |
ns-rse
left a comment
There was a problem hiding this comment.
Great work burning through these @SylviaWhittle
Some comments inline.
You'll likely encounter merge conflicts in the subsequent commits, in the README.md and possibly example_01.ipynb. They should be straight-forward to resolve though.
f5eb9de to
fcb12a9
Compare
Co-authored-by: Neil Shephard <n.shephard@sheffield.ac.uk>
Re-writing example in docstring to use [doctest format](https://numpydoc.readthedocs.io/en/latest/format.html#examples).
Add file type: SPM
Co-authored-by: Neil Shephard <n.shephard@sheffield.ac.uk>
Re-writing example in docstring to use [doctest format](https://numpydoc.readthedocs.io/en/latest/format.html#examples). Minor tpyo in README.md corrected.
…fileformats into SylviaWhittle/file-type-ibw
ns-rse
left a comment
There was a problem hiding this comment.
Can't understand why all the other changes have appeared on this branch, particularly as they are already on main.
One tiny suggestion for the disabled pylint to make it easier for readers to know what has been disabled otherwise ready to go.
Closes #17
This PR adds IBW support
Just basic loading of
.ibwfiles, akin to how I did.spm.