Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 65.87% 66.58% +0.71%
==========================================
Files 3 5 +2
Lines 337 413 +76
==========================================
+ Hits 222 275 +53
- Misses 115 138 +23 ☔ View full report in Codecov by Sentry. |
ns-rse
requested changes
Apr 24, 2024
Collaborator
ns-rse
left a comment
ns-rse
left a comment
There was a problem hiding this comment.
Thanks @SylviaWhittle as with other PRs out some comments in-line.
Not sure what your plan is for integrating with TopoStats but we could likely use the "factory method" design pattern to select the correct loader based on file extensions.
SylviaWhittle
force-pushed
the
SylviaWhittle/file-type-spm
branch
from
0d4633c to
c2fe677
Compare
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2) - [github.com/psf/black-pre-commit-mirror: 24.4.0 → 24.4.2](psf/black-pre-commit-mirror@24.4.0...24.4.2)
Co-authored-by: Neil Shephard <n.shephard@sheffield.ac.uk>
…fileformats into SylviaWhittle/file-type-spm
Re-writing example in docstring to use [doctest format](https://numpydoc.readthedocs.io/en/latest/format.html#examples).
Re-writing example in docstring to use [doctest format](https://numpydoc.readthedocs.io/en/latest/format.html#examples).
Add file type: JPK
Co-authored-by: Neil Shephard <n.shephard@sheffield.ac.uk>
Re-writing example in docstring to use [doctest format](https://numpydoc.readthedocs.io/en/latest/format.html#examples).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
This PR adds SPM support.
Just basic loading of
.spmfiles, akin to how I did.asd.