Repository navigation
bump-xdna: correct the XRT path in the PR's test recipe - #82
Merged
Merged
Conversation
build-xdna.sh installs there; ONEBIT_XRT_ROOT=<prefix> fails to configure (found verifying #76). XILINX_XRT points XRT at the new driver plugin for the lane test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Reviewer Guide 🔍(Review updated until commit 45c2963)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit a806941 |
|
Persistent review updated to latest commit b0cd956 |
|
Persistent review updated to latest commit 45c2963 |
This was referenced Oct 5, 2026
bong-water-water-bong
added a commit
that referenced
this pull request
Oct 5, 2026
…to our fork (Loom NaN backport) (#320) * Bump HRX: llama.cpp 522dab4789ce (long-prompt fix), hrx-system to our fork 98d05d94a9f9 third_party/llama.cpp e57beb9721af -> 522dab4789ce (fork #89 runtime overhead, #90: graph inputs never written back to host — every multi-ubatch prompt was wrong since #82 — and the non-replay upload race). third_party/hrx-system moves from ROCm/hrx-system 51b1739ae5fd to our fork 1bit-MONSTER/hrx-system 1bit/main 98d05d94a9f9 = the same AMD commit plus the GFX11 wave64 lane-mask drain backport (#313 NaN) and two libhrx device knobs. bump-hrx.yml now moves only the llama.cpp pin; hrx-system is rebased by hand. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * registry: regenerated at llama.cpp 522dab4789ce Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while verifying #76:
build-xdna.sh <prefix>installs XRT at<prefix>/root/opt/xilinx/xrt, so the recipe's-DONEBIT_XRT_ROOT=<prefix>fails to configure. The recipe now uses the install path, and setsXILINX_XRTso the lane test loads the new driver plugin.🤖 Generated with Claude Code