Skip to content

feat(checkpoint): propagate stable execution identity - #1

Open
zyzhou5 wants to merge 1 commit into
mainfrom
study-2939
Open

zyzhou5 wants to merge 1 commit into
mainfrom
study-2939

Conversation

@zyzhou5

@zyzhou5 zyzhou5 commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Keep the logical rollout ID and attempt index independent from the attempt-qualified capture key so checkpoint participants can fence retries without depending on capture configuration. Expose the authoritative model call ID on captured responses for later boundary reconciliation.

(cherry picked from commit cd3de54)

Retarget the PR NVIDIA-NeMo#2939 identity change onto current main. Preserve main's training-only capture failure handling when adding the model-call ID header.

What does this PR do?

Validation

Rollouts

Compatibility and benchmark impact

Checklist

  • I have read the contributing guidelines.
  • The change is focused; unrelated "drive-by" edits are tracked as separate issues/PRs.
  • Tests added or updated and pass locally, or N/A for docs-only / non-code changes (so CI unit/server checks pass when applicable).
  • Documentation added or updated, or N/A with justification.
  • Pre-commit checks pass locally (pre-commit run --all-files) (so CI lint/format checks pass).
  • New source files include the required Apache-2.0 SPDX header.
  • All commits have DCO sign-off (git commit -s) (so the DCO check passes).

Keep the logical rollout ID and attempt index independent from the attempt-qualified capture key so checkpoint participants can fence retries without depending on capture configuration. Expose the authoritative model call ID on captured responses for later boundary reconciliation.

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>

(cherry picked from commit cd3de54)

Retarget the PR NVIDIA-NeMo#2939 identity change onto current main. Preserve main's
training-only capture failure handling when adding the model-call ID header.

Signed-off-by: Zeyu Zhou <zezhou@nvidia.com>
@github-actions github-actions Bot added the sla:triage-overdue Review assignment is over the one-business-day SLA label Sep 23, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions Bot added Stale and removed sla:triage-overdue Review assignment is over the one-business-day SLA labels Oct 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants