Repository navigation
sync-upstream check: React Compiler build, touched tests, fork release links - #32
Merged
Merged
Conversation
…ouched tests, flag fork release links
The check passed the 2026-10-19 sync locally, then CI rejected it. It now also:
- builds the web app with the React Compiler reporting every component it skips
- runs the test files the sync added or changed, through each package's own test script
- fails when a built web file names the fork (no releases there)
Refuses to run on a Node other than package.json's. Resolves ziyadakl/tokenmaxxing#80.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pts.test, node --test for .github scripts, clean scratch files, NO_COLOR build Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ziyadakl
marked this pull request as ready for review
October 20, 2026 03:30
…uched tests, as CI does Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves ziyadakl/tokenmaxxing#80 (part of pingdotgg#77).
Summary
Fork builds got
GITHUB_REPOSITORY=ziyadakl/t3code, so the "what's new" link pointed at a fork with no releases. The check builds with that value plus the release workflow'sT3CODE_DESKTOP_UPDATE_REPOSITORY, then grepsapps/web/dist.Evidence
Fork PR #31 commits:
581e7c3fb4(CI failed: Test Web, Test) and7ca6fcf557(CI green).581e7c3fb4):sync-upstream.sh checkexit 1:[plugin vite:react-compiler] try/finally without catch is not supported by React Compiler(ChatView.tsx:5827, :5990; BrowserImportLauncher.tsx:156), thenReact Compiler skipped the components above. CI rejects them.Without the compiler step, the release-link step alone also failed:
These built files name ziyadakl/t3code, which has no releases(3 files).7ca6fcf557), on affinity-vps, Node 24: lint, typecheck, knip, the compiler build (no[plugin vite:react-compiler]lines) and the release-link check pass. Touched tests: 6005 server and 5184 web pass. Exit 1 only frombrowserType.launch: Executable doesn't exist at ~/.cache/ms-playwright/chromium_headless_shell-1223. The server had Chromium 1194 and 1243, not the 1223 this commit's Playwright pins. Fixed in3208dc00: before touched tests the check runs CI's ownplaywright install --only-shell chromiumfor apps/web and apps/server. On affinity-vps that downloadedchromium_headless_shell-1223, the missing build.581e7c3fb4on affinity-vps: exit 1, endingReact Compiler skipped the components above. CI rejects them.bash scripts/custom/sync-upstream.test.sh->all passed(adds cases for a bad base, a package with notestscript, and.github/scripts/*.test.cjsgoing tonode --test). shellcheck clean.Merge Danger
Door: two-way. Revert restores the old check.
Blast Radius: sync-only
Touches only
scripts/custom/sync-upstream.sh, its test andCUSTOM.md; no app code, no CI workflow. Built for affinity-vps (Linux); about 30 min there for this sync. On the Mac it fails on Mac-only causes (launcher-version and/private/varpath tests). A sync that bumps Playwright downloads its Chromium build (~113 MB) into~/.cache/ms-playwright; Playwright then drops builds no installed package uses. A sync with a huge upstream delta runs near the whole suite.🤖 Generated with Claude Code