Skip to content

sync-upstream check: React Compiler build, touched tests, fork release links - #32

Merged
ziyadakl merged 3 commits into
custom-v2from
retro/sync-check-80
Oct 20, 2026
Merged

ziyadakl merged 3 commits into
custom-v2from
retro/sync-check-80

Conversation

@ziyadakl

@ziyadakl ziyadakl commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Resolves ziyadakl/tokenmaxxing#80 (part of pingdotgg#77).

Summary

 check
   ensure:electron, knip:check, vp check, vpr typecheck, lint:mobile
+  refuse a Node other than package.json's
+  web build, React Compiler on, every skipped component reported -> fail
+  built web files that name the fork -> fail
+  touched test files (vs pre-sync custom-v2), per package, via its own `test` script -> fail

Fork builds got GITHUB_REPOSITORY=ziyadakl/t3code, so the "what's new" link pointed at a fork with no releases. The check builds with that value plus the release workflow's T3CODE_DESKTOP_UPDATE_REPOSITORY, then greps apps/web/dist.

Evidence

Fork PR #31 commits: 581e7c3fb4 (CI failed: Test Web, Test) and 7ca6fcf557 (CI green).

  • Before (581e7c3fb4): sync-upstream.sh check exit 1:
    [plugin vite:react-compiler] try/finally without catch is not supported by React Compiler (ChatView.tsx:5827, :5990; BrowserImportLauncher.tsx:156), then
    React Compiler skipped the components above. CI rejects them.
    Without the compiler step, the release-link step alone also failed: These built files name ziyadakl/t3code, which has no releases (3 files).
  • After (7ca6fcf557), on affinity-vps, Node 24: lint, typecheck, knip, the compiler build (no [plugin vite:react-compiler] lines) and the release-link check pass. Touched tests: 6005 server and 5184 web pass. Exit 1 only from browserType.launch: Executable doesn't exist at ~/.cache/ms-playwright/chromium_headless_shell-1223. The server had Chromium 1194 and 1243, not the 1223 this commit's Playwright pins. Fixed in 3208dc00: before touched tests the check runs CI's own playwright install --only-shell chromium for apps/web and apps/server. On affinity-vps that downloaded chromium_headless_shell-1223, the missing build.
  • 581e7c3fb4 on affinity-vps: exit 1, ending React Compiler skipped the components above. CI rejects them.
  • Helper tests: bash scripts/custom/sync-upstream.test.sh -> all passed (adds cases for a bad base, a package with no test script, and .github/scripts/*.test.cjs going to node --test). shellcheck clean.

Merge Danger

Door: two-way. Revert restores the old check.

Blast Radius: sync-only

Touches only scripts/custom/sync-upstream.sh, its test and CUSTOM.md; no app code, no CI workflow. Built for affinity-vps (Linux); about 30 min there for this sync. On the Mac it fails on Mac-only causes (launcher-version and /private/var path tests). A sync that bumps Playwright downloads its Chromium build (~113 MB) into ~/.cache/ms-playwright; Playwright then drops builds no installed package uses. A sync with a huge upstream delta runs near the whole suite.

🤖 Generated with Claude Code

…ouched tests, flag fork release links

The check passed the 2026-10-19 sync locally, then CI rejected it. It now also:
- builds the web app with the React Compiler reporting every component it skips
- runs the test files the sync added or changed, through each package's own test script
- fails when a built web file names the fork (no releases there)

Refuses to run on a Node other than package.json's. Resolves ziyadakl/tokenmaxxing#80.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Oct 20, 2026
…pts.test, node --test for .github scripts, clean scratch files, NO_COLOR build

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ziyadakl
ziyadakl marked this pull request as ready for review October 20, 2026 03:30
…uched tests, as CI does

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ziyadakl
ziyadakl merged commit de32cf4 into custom-v2 Oct 20, 2026
25 of 26 checks passed
@ziyadakl
ziyadakl deleted the retro/sync-check-80 branch October 20, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants