Skip to content

Open the / list for skills in the middle of a sentence - #17

Closed
ziyadakl wants to merge 2 commits into
custom-v2from
fix/inline-slash-picker
Closed

ziyadakl wants to merge 2 commits into
custom-v2from
fix/inline-slash-picker

Conversation

@ziyadakl

@ziyadakl ziyadakl commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Summary

detectComposerTrigger(text, cursor)
  "/" opens the line        -> slash list (unchanged)
  "/name" after other text  -> slash list, inline: true   (new)
  "and/or", "/etc/hosts"    -> nothing

slashCommandItemsForPromptPosition(items, position)
  prompt-start -> everything
  line-start   -> built-ins + skills
  mid-line     -> skills only   (new; they insert a $ chip that runs anywhere)

Evidence

  • Before: typing hey can u /ask opened no list. New tests failed: expected null to deeply equal { kind: 'slash-command', … } (4 failed).
    After: vp test run src/composer-logic.test.ts src/components/chat/composerSlashCommandSearch.test.ts → 97 passed.

Merge Danger

Door: two-way

Revert the commit to restore the old list behavior.

Blast Radius: small

Only changes when the / list opens in the composer. Message sending and skill dispatch are untouched.

🤖 Generated with Claude Code

Typing "/ask" after other text on a line now opens the slash list,
showing only skills. Skills insert a $ chip that runs from anywhere.
Provider and T3 commands still need the start of a line, where they work.
A slash inside a word or path, like and/or or /etc/hosts, opens nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@ziyadakl ziyadakl closed this Oct 9, 2026
@ziyadakl ziyadakl reopened this Oct 9, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@ziyadakl

Copy link
Copy Markdown
Owner Author

Closing: upstream now ships this. a01c48f opens the / list at any word, and deb5b39 keeps paths like /etc/hosts from opening it. Both came into custom-v2 with the upstream sync in #31. One difference: mid-sentence, upstream also lists /model and /plan.

@ziyadakl ziyadakl closed this Oct 19, 2026
@ziyadakl
ziyadakl deleted the fix/inline-slash-picker branch October 19, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants