fix: PHP 8.5 deprecation for null as array offset#2032
Merged
DerManoMann merged 1 commit intoJun 29, 2026
Merged
Conversation
Use null-coalescing with Generator::UNDEFINED to guard against null key-field values in serialization and validation. Adds tests that trigger the deprecation on unpatched code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3783548 to
5d949d9
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?? Generator::UNDEFINEDpattern for null-safe key-field checks in AbstractAnnotationparameter/namein AugmentParametersImproves and supersedes #2004 from @hotrush
Test plan