Fix SGI 64-bit RGBA reading alpha from wrong buffer#328
Open
IfkumRfnl wants to merge 1 commit into
Open
Conversation
The .rgba64 path used u16_buffer for r, g and b but buffer (u8) for the alpha channel, returning a truncated byte instead of the real 16-bit alpha. Other formats are unaffected. Adds a test that constructs a 2x2 16-bit RGBA SGI file and asserts all four alpha values; values chosen so the buggy u8 read fails every assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug where wrong buffer was used for alpha channel in SGI
Details
https://github.com/zigimg/zigimg/blob/master/src%2Fformats%2Fsgi.zig#L278
here code uses
u16_bufferfor reading r, g and b channels but usesbufferfor alpha channel, seems like a typo