Skip to content

fix: regenerate from nebula@fca50a0 - #584

Open
nebula-sdk-bot[bot] wants to merge 1 commit into
mainfrom
auto/sdk-regen-fca50a0
Open

nebula-sdk-bot[bot] wants to merge 1 commit into
mainfrom
auto/sdk-regen-fca50a0

Conversation

@nebula-sdk-bot

Copy link
Copy Markdown
Contributor

Automated SDK regeneration.

Source: zeroset-inc/nebula@fca50a0
Generator: nebula-sdks/generator (@workos/oagen-backed)
Bump type: fix (drives release-please's next version)

Review the diff carefully — this is a release artifact. The in-tree
pyproject.toml version is 0.0.0+from-source; release-please
owns the published version.

@zeroset-agent zeroset-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero Review - 2 findings shown inline.

4,662,532 tokens used (4,629,100 prompt / 33,432 completion; 4,100,608 served from cache, billed ~10%).

Models - prime-root: zero/swe-root (1 agent, 1 task, 43 calls, 2,583,103 tokens), prime-child: zero/balanced (5 agents, 5 tasks, 69 calls, 2,079,429 tokens)

Comment thread src/nebula/_client.py
self.collections: CollectionsResource = CollectionsResource(self._core)
self.connectors: ConnectorsResource = ConnectorsResource(self._core)
self.memories: MemoriesResource = MemoriesResource(self._core)
self.enterprise: EnterpriseResource = EnterpriseResource(self._core)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Preserve the existing memory API aliases

This replacement removes NebulaClient.memories, while the same regeneration also deletes Nebula.store_memory() and store_memories() from the DX facade. Those are existing public entry points, and the migration guide still instructs users to call them and describes store_memories as available. A probe against this head confirms that Nebula.store_memory, Nebula.store_memories, and NebulaClient.memories are all absent. Existing applications will therefore fail immediately with AttributeError after what is labeled a fix release. Keep compatibility aliases/wrappers (even if deprecated) or explicitly treat and document this as a breaking release.

Evidence

  • At the merge base, NebulaClient initializes self.memories, and Nebula implements store_memory plus store_memories.
  • Head probe: Nebula store_memory False store_memories False; NebulaClient instance memories False memory True.
  • MIGRATION.md at head still calls client.store_memory and advertises store_memories.

# the misroute is transient; the edge replays what it can, and retrying
# covers the requests it cannot (uncloneable bodies, unannotated routes).
_RETRYABLE_STATUSES: frozenset[int] = frozenset({421, 429, 503})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Continue retrying transient 408/502/504 responses

The retry set drops 408, 502, and 504, so even generated methods marked retryable: True now surface common transient request-timeout and gateway failures on the first response. This regresses the previous policy and is especially problematic for idempotent GET/DELETE operations where replay is safe. A focused probe configured client.health() with two retries and a transport returning 502; the transport was invoked only once. Add these transient statuses back unless the service contract explicitly guarantees they cannot occur.

Evidence

  • The merge-base retry set was {408, 429, 502, 503, 504}.
  • Head status probe reports 408=False, 502=False, and 504=False.
  • Focused 502 test on retryable client.health() with max_retries=2 produced calls 1.

@zeroset-agent

zeroset-agent Bot commented Aug 27, 2026

Copy link
Copy Markdown

Zero Review

Summary

  • 0 critical, 2 warnings, 0 nits
  • 4,662,532 tokens used (4,629,100 prompt / 33,432 completion; 4,100,608 served from cache, billed ~10%)
  • Models - prime-root: zero/swe-root (1 agent, 1 task, 43 calls, 2,583,103 tokens), prime-child: zero/balanced (5 agents, 5 tasks, 69 calls, 2,079,429 tokens)
  • Sandbox review mode: full checkout and tool-backed review executed.

2 per-line findings posted in the inline review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants