Repository navigation
fix: regenerate from nebula@fca50a0 - #584
nebula-sdk-bot[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Zero Review - 2 findings shown inline.
4,662,532 tokens used (4,629,100 prompt / 33,432 completion; 4,100,608 served from cache, billed ~10%).
Models - prime-root: zero/swe-root (1 agent, 1 task, 43 calls, 2,583,103 tokens), prime-child: zero/balanced (5 agents, 5 tasks, 69 calls, 2,079,429 tokens)
| self.collections: CollectionsResource = CollectionsResource(self._core) | ||
| self.connectors: ConnectorsResource = ConnectorsResource(self._core) | ||
| self.memories: MemoriesResource = MemoriesResource(self._core) | ||
| self.enterprise: EnterpriseResource = EnterpriseResource(self._core) |
There was a problem hiding this comment.
🟡 Preserve the existing memory API aliases
This replacement removes NebulaClient.memories, while the same regeneration also deletes Nebula.store_memory() and store_memories() from the DX facade. Those are existing public entry points, and the migration guide still instructs users to call them and describes store_memories as available. A probe against this head confirms that Nebula.store_memory, Nebula.store_memories, and NebulaClient.memories are all absent. Existing applications will therefore fail immediately with AttributeError after what is labeled a fix release. Keep compatibility aliases/wrappers (even if deprecated) or explicitly treat and document this as a breaking release.
Evidence
- At the merge base, NebulaClient initializes
self.memories, and Nebula implementsstore_memoryplusstore_memories. - Head probe:
Nebula store_memory False store_memories False;NebulaClient instance memories False memory True. - MIGRATION.md at head still calls
client.store_memoryand advertisesstore_memories.
| # the misroute is transient; the edge replays what it can, and retrying | ||
| # covers the requests it cannot (uncloneable bodies, unannotated routes). | ||
| _RETRYABLE_STATUSES: frozenset[int] = frozenset({421, 429, 503}) | ||
|
|
There was a problem hiding this comment.
🟡 Continue retrying transient 408/502/504 responses
The retry set drops 408, 502, and 504, so even generated methods marked retryable: True now surface common transient request-timeout and gateway failures on the first response. This regresses the previous policy and is especially problematic for idempotent GET/DELETE operations where replay is safe. A focused probe configured client.health() with two retries and a transport returning 502; the transport was invoked only once. Add these transient statuses back unless the service contract explicitly guarantees they cannot occur.
Evidence
- The merge-base retry set was
{408, 429, 502, 503, 504}. - Head status probe reports 408=False, 502=False, and 504=False.
- Focused 502 test on retryable
client.health()with max_retries=2 producedcalls 1.
Zero ReviewSummary
2 per-line findings posted in the inline review. |
Automated SDK regeneration.
Source: zeroset-inc/nebula@fca50a0
Generator: nebula-sdks/generator (@workos/oagen-backed)
Bump type:
fix(drives release-please's next version)Review the diff carefully — this is a release artifact. The in-tree
pyproject.tomlversion is0.0.0+from-source; release-pleaseowns the published version.