Skip to content

Add native Windows caption controls - #16

Merged
wingleeio merged 1 commit into
zeronsh:mainfrom
xptea:agent/windows-caption-controls
Aug 4, 2026
Merged

wingleeio merged 1 commit into
zeronsh:mainfrom
xptea:agent/windows-caption-controls

Conversation

@xptea

@xptea xptea commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add native Windows caption controls to Comet's unified titlebar
  • expose the controls across loading, authentication, organization, error, settings, and chat views
  • reserve titlebar space so tabs and settings content do not overlap the controls

Why

Windows used a frameless titlebar but did not render minimize, maximize/restore, or close controls. This made the window difficult to manage and left pre-login views without window chrome.

Validation

  • cargo build -p comet
  • cargo test -p comet-ui --lib shell::tests:: (18 passed)
  • cargo test -p comet-ui --lib (357 passed; existing Windows IPC port-release test failed)
  • manual verification on Windows, including loading and sign-in views

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@wingleeio

Copy link
Copy Markdown
Contributor

Are you able to provide video/images of how this looks on windows?

@xptea

xptea commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Are you able to provide video/images of how this looks on windows?

Sure! This change adds native window decorations to every page on Windows. Previously, the window was frameless, so there were no standard controls to minimize, maximize, or close it.

image image image

@wingleeio wingleeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff: pure UI change, no dependency/CI/build-script modifications, no unsafe or Win32 calls, and a byte-level scan found no invisible Unicode. Safe to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants