Repository navigation
Add native Windows caption controls - #16
Merged
Merged
Conversation
Contributor
|
Are you able to provide video/images of how this looks on windows? |
Contributor
Author
wingleeio
approved these changes
Aug 4, 2026
wingleeio
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the diff: pure UI change, no dependency/CI/build-script modifications, no unsafe or Win32 calls, and a byte-level scan found no invisible Unicode. Safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Why
Windows used a frameless titlebar but did not render minimize, maximize/restore, or close controls. This made the window difficult to manage and left pre-login views without window chrome.
Validation
cargo build -p cometcargo test -p comet-ui --lib shell::tests::(18 passed)cargo test -p comet-ui --lib(357 passed; existing Windows IPC port-release test failed)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.