Change occurrences of format() to f-strings#439
Merged
dstansby merged 4 commits intozarr-developers:mainfrom Aug 21, 2024
Merged
Change occurrences of format() to f-strings#439dstansby merged 4 commits intozarr-developers:mainfrom
dstansby merged 4 commits intozarr-developers:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
- Coverage 99.91% 99.91% -0.01%
==========================================
Files 59 59
Lines 2339 2334 -5
==========================================
- Hits 2337 2332 -5
Misses 2 2
|
DimitriPapadopoulos
force-pushed
the
f-strings
branch
from
4e24e85 to
6f37b35
Compare
DimitriPapadopoulos
force-pushed
the
f-strings
branch
from
6f37b35 to
cb19741
Compare
DimitriPapadopoulos
force-pushed
the
f-strings
branch
2 times, most recently
from
d781c17 to
7261c1e
Compare
Contributor
|
Looks good in theory, but is there a ruff rule (or similar) we can enable to automate making sure this change stays in the future? |
DimitriPapadopoulos
force-pushed
the
f-strings
branch
4 times, most recently
from
66fec9b to
cecee04
Compare
Contributor
Author
|
I have enabled the relevant ruff rules A small part of the changes is manual, because ruff currently doesn't catch all issues. |
DimitriPapadopoulos
force-pushed
the
f-strings
branch
4 times, most recently
from
67757e1 to
ba8e691
Compare
dstansby
reviewed
Aug 11, 2024
DimitriPapadopoulos
force-pushed
the
f-strings
branch
from
ba8e691 to
2831bac
Compare
UP006 Use `tuple` instead of `Tuple` for type annotation UP035 `typing.Dict` is deprecated, use `dict` instead UP035 `typing.Tuple` is deprecated, use `tuple` instead UP035 `typing.Type` is deprecated, use `type` instead
DimitriPapadopoulos
force-pushed
the
f-strings
branch
from
2831bac to
367e575
Compare
dstansby
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also change one occurrence of
%toformat(), as changing to an f-string would result in a very long line.TODO: