refactor!: move template out of internal - #5212
Open
a1994sc wants to merge 2 commits into
Open
Conversation
Signed-off-by: Allen Conlon <software@conlon.dev>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
AustinAbro321
left a comment
AustinAbro321
left a comment
Member
There was a problem hiding this comment.
Small comment and question, but I agree with the direction
| ptmpl "github.com/zarf-dev/zarf/src/internal/packager/template" | ||
| "github.com/zarf-dev/zarf/src/internal/template" | ||
| "github.com/zarf-dev/zarf/src/pkg/logger" | ||
| "github.com/zarf-dev/zarf/src/pkg/packager/template" |
Member
There was a problem hiding this comment.
I think I'd rather have the template path be src/pkg/template than src/pkg/packager/template. While it does have functions like WithPackage it is generally agnostic, and could be used outside of the context of a Zarf package.
Contributor
Author
There was a problem hiding this comment.
I am totally fine with that, mostly guessed where to put it, ha
Signed-off-by: Allen Conlon <software@conlon.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the previously internal package to under
src/pkg/packagerRelated Issue
Fixes #5211
Checklist before merging