feat: direct verification of bundle with sigstore-go - #5177
Open
brandtkeller wants to merge 9 commits into
Open
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
brandtkeller
commented
Aug 7, 2026
| } | ||
|
|
||
| hasKey := opts.Key != "" | ||
| hasKey := opts.Key != "" || opts.SecurityKey.Use |
Member
Author
There was a problem hiding this comment.
Not exposed by the CLI but potentially supported by the SDK given the broader VerfiyBlobOptions.
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
brandtkeller
marked this pull request as ready for review
August 7, 2026 22:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the removal of producing any legacy signatures and only defaulting to the sigstore bundle format we can now begin looking at migrating from the use of Cosign to Sigstore.
We still require the existing Cosign logic for legacy signatures - which we've been preserving for the ability to perform verification of older packages without the bundle format - yet we can begin integrating new sigstore functionality that can eventually allow us to deprecate and remove the cosign logic.
A full migration spike is still underway - but verification itself is more isolated and less complex than the requirements for signing.
This PR add direct sigstore bundle verification with parity to Cosign for supported options and as such it no longer emits the
Verified OKmessage to stderr upon verification.Moving the blank KMS provider imports to a neutral location such that they are not inadvertently lost between any future migration work as this sigstore implementation does rely on them for parity.
Adds some additional testing and highlights some features that we don't tend to broadcast (such as public key retrieval from an environment variable or kubernetes.
Related Issue
Fixes #5172
Relates to #
Checklist before merging