chore(deps): bump github.com/gabriel-vasile/mimetype from 1.4.13 to 1.4.15 - #5140
Open
dependabot[bot] wants to merge 1 commit into
Open
chore(deps): bump github.com/gabriel-vasile/mimetype from 1.4.13 to 1.4.15#5140dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype) from 1.4.13 to 1.4.15. - [Release notes](https://github.com/gabriel-vasile/mimetype/releases) - [Commits](gabriel-vasile/mimetype@v1.4.13...v1.4.15) --- updated-dependencies: - dependency-name: github.com/gabriel-vasile/mimetype dependency-version: 1.4.15 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
✅ Deploy Preview for zarf-docs canceled.
|
Member
|
Before accepting this PR I am evaluating these based on what function they serve. This dependency is used solely by the pull logic for a package from http/https. The file has already been downloaded and we're detecting the file type extension. IMO the existing archives dependency holds better fidelity of the contract is merely .tar/.tar.zst. Otherwise the alternative would be removing the http/https pull all-together but that feels a bit extreme. Thoughts @zarf-dev/maintainers / @zarf-dev/reviewers ? |
Member
|
@brandtkeller Yeah, I think we can replace this with the archives filetype detection It would still be an in-direct dependency, but that's a still a win IMO. |
Contributor
|
Totally agree with minimizing our deps surface. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/gabriel-vasile/mimetype from 1.4.13 to 1.4.15.
Release notes
Sourced from github.com/gabriel-vasile/mimetype's releases.
... (truncated)
Commits
f6bb955readme: add back contributing section, for #827 (#831)1b3ab2efuzz: fuzz for 32 bit too to avoid panics like #829 (#830)38e5e71cdf: fix slice index panic on 32bit arch (#829)bcd718dgedcom: add support for text/vnd.familysearch.gedcom (#789)2995287build(deps): bump the github-actions group across 1 directory with 7 updates ...14cefcbfuzz: improvements for exploring more code paths (#824)5b11e3ascan: fix panic and fuzz flags (#823)5621f29charset: stop checking for ascii if utf8 is satisfied (#768)eb8d3f4docs: mention String() can return different values (#820)9268756mkv: use IANA registered media type video/matroska (#819)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)