Migrate credential storage to sailfish-secrets#2
Merged
Conversation
Replace custom HMAC-SHA256 CTR-mode encryption with Sailfish OS native sailfish-secrets framework. Uses CollectionSecret with DeviceLockKeepUnlocked and SystemInteraction mode. Changes: - Add ICredentialStore interface for testability - Rewrite CredentialStore to use sailfish-secrets (CollectionSecret) - Move old implementation to FileCredentialStore (test-only) - Update daemon and loginhelper to use ICredentialStore - Add sailfishsecrets build deps to .pro, .spec, .desktop - Update tests to use FileCredentialStore with renamed enum values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the custom file-based credential encryption with Sailfish OS's native secrets framework. Credentials are now stored in the system encrypted secrets database instead of a custom HMAC-SHA256 JSON file.
Also fixes notification taps opening a duplicate app instance when the app is already running.
Changes:
ICredentialStoreinterface — old file-based implementation kept as test-only (FileCredentialStore)/procbefore launching — skips invoker if UI is already runningRuntime dependency:
sailfishsecretsdaemon-secretsplugins-default