MNT: migrate away from packaging.version.parse#3494
Merged
matthewturk merged 1 commit intoyt-project:mainfrom Oct 9, 2021
Merged
MNT: migrate away from packaging.version.parse#3494matthewturk merged 1 commit intoyt-project:mainfrom
matthewturk merged 1 commit intoyt-project:mainfrom
Conversation
Member
Author
|
A possible alternative is to build our own |
84d3008 to
3c81ad8
Compare
Xarthisius
approved these changes
Sep 24, 2021
…ism is going away in a future version
3c81ad8 to
3f576bd
Compare
42 tasks
Member
Author
|
@meeseeksdev backport to yt-4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Nov 6, 2021
neutrinoceros
pushed a commit
to neutrinoceros/yt
that referenced
this pull request
Nov 7, 2021
MNT: migrate away from packaging.version.parse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently,
packaging.version.parse_versionis implemented asbut
LegacyVersionis deprecated since pypa/packaging#342and the plan for their next release is to have
packaging.version.parsebasically be an alias forpackaging.version.Version.__init__, see pypa/packaging#407So I'm proposing we move forward with it and stop using the
parsefunction as it may cause confusion in the future and is more complicated to use.Note that since we're now treating warnings as errors in CI (#3380) means that we can switch with confidence because we know that we don't currently have any such warnings to deal with.