Repository navigation
Conversation
added 2 commits
October 13, 2026 00:06
The decode TPS chart hides the uPlot legend, so the crosshair showed no value. A small uPlot plugin now puts a label next to the cursor with the time and the value of each visible series, taken from the nearest point within 40 px (live samples and completed requests sit at different times, so the exact index is often empty for one of them). The label flips to the left near the right edge. The bundled SPA in mtplx/dashboard/_static needs a rebuild to pick this up.
jvmenen
pushed a commit
to jvmenen/MTPLX
that referenced
this pull request
Oct 13, 2026
…ofal#626) and the waterfall per round (youssofal#590)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On the Overview tab, hovering the "Decode TPS (last 5 min)" chart draws the crosshair but shows no number. The chart hides the uPlot legend, so there is no place where the value under the cursor appears. To read the tok/s at a dip or a peak you have to estimate it from the y axis.
What changes
lib/uplotTooltip.ts(new): a small uPlot plugin,cursorValueTooltip(formatValue), that puts a label next to the crosshair.TPSTimeSeries.tsx: one line that turns the plugin on, formatting values asNN.N tok/s.How it works, in plain terms
On every cursor move the plugin looks up, for each visible series, the data point nearest to the cursor and shows the time and that value, with a dot in the series colour. It searches outwards from the hovered index and only accepts points within 40 px, because a series with gaps or sparse dots (such as completed requests next to live samples) is often empty at the exact index under the cursor. When no series has a point that close, no label is shown. Near the right edge the label flips to the left of the crosshair so it stays inside the plot. The legend stays hidden and nothing else about the chart changes.
Tests
tsc -b && vite buildpasses.bun testwas not run here (bun is not installed on this machine); the change adds no props or hooks that the existinguplotAxis.test.tsmocks.