This repository was archived by the owner on May 22, 2025. It is now read-only.
Makes bloodbrothers start with the makeshift weapons book learned. (Jamie Edition)#14094
Merged
JamieD1 merged 5 commits intoyogstation13:masterfrom May 22, 2022
opensuspect:bloodbrothers-not-shitty
Merged
Makes bloodbrothers start with the makeshift weapons book learned. (Jamie Edition)#14094JamieD1 merged 5 commits intoyogstation13:masterfrom opensuspect:bloodbrothers-not-shitty
JamieD1 merged 5 commits intoyogstation13:masterfrom
opensuspect:bloodbrothers-not-shitty
Conversation
tattax
reviewed
May 10, 2022
Comment on lines
+31
to
+36
| var/list/crafting_recipe_types = list(/datum/crafting_recipe/baseball_bat, /datum/crafting_recipe/lance, /datum/crafting_recipe/knifeboxing, /datum/crafting_recipe/flamethrower, /datum/crafting_recipe/pipebomb, /datum/crafting_recipe/makeshiftpistol, /datum/crafting_recipe/makeshiftmagazine, /datum/crafting_recipe/makeshiftsuppressor, /datum/crafting_recipe/makeshiftcrowbar, /datum/crafting_recipe/makeshiftwrench, /datum/crafting_recipe/makeshiftwirecutters, /datum/crafting_recipe/makeshiftweldingtool, /datum/crafting_recipe/makeshiftmultitool, /datum/crafting_recipe/makeshiftscrewdriver, /datum/crafting_recipe/makeshiftknife, /datum/crafting_recipe/makeshiftpickaxe, /datum/crafting_recipe/makeshiftradio) | ||
|
|
||
| for(var/crafting_recipe_type in crafting_recipe_types) | ||
| var/datum/crafting_recipe/R = crafting_recipe_type | ||
| owner.teach_crafting_recipe(crafting_recipe_type) | ||
| to_chat(owner,span_notice("You learned how to make [initial(R.name)].")) |
Contributor
There was a problem hiding this comment.
Suggested change
| var/list/crafting_recipe_types = list(/datum/crafting_recipe/baseball_bat, /datum/crafting_recipe/lance, /datum/crafting_recipe/knifeboxing, /datum/crafting_recipe/flamethrower, /datum/crafting_recipe/pipebomb, /datum/crafting_recipe/makeshiftpistol, /datum/crafting_recipe/makeshiftmagazine, /datum/crafting_recipe/makeshiftsuppressor, /datum/crafting_recipe/makeshiftcrowbar, /datum/crafting_recipe/makeshiftwrench, /datum/crafting_recipe/makeshiftwirecutters, /datum/crafting_recipe/makeshiftweldingtool, /datum/crafting_recipe/makeshiftmultitool, /datum/crafting_recipe/makeshiftscrewdriver, /datum/crafting_recipe/makeshiftknife, /datum/crafting_recipe/makeshiftpickaxe, /datum/crafting_recipe/makeshiftradio) | |
| for(var/crafting_recipe_type in crafting_recipe_types) | |
| var/datum/crafting_recipe/R = crafting_recipe_type | |
| owner.teach_crafting_recipe(crafting_recipe_type) | |
| to_chat(owner,span_notice("You learned how to make [initial(R.name)].")) | |
| var/obj/item/book/granter/crafting_recipe/weapons/W | |
| for(var/datum/crafting_recipe/R in W.crafting_recipe_types) | |
| owner.teach_crafting_recipe(R) | |
| to_chat(owner,span_notice("You learned how to make [initial(R.name)].")) |
Contributor
Author
There was a problem hiding this comment.
thank you very cool
Contributor
There was a problem hiding this comment.
do this so we don't have to update it as well as the crafting book every time something new gets added
Contributor
|
What we doing with this, |
|
are we going to have both minor bb rework and this or only this or only minor bb rework. if we are gonna only have one of then there should be a quickfire vote about this. |
Contributor
Author
|
closing this because i personally believe the other blood brother rework is a better choice |
Contributor
|
I prefer this one to be honest. |
JamieD1
approved these changes
May 22, 2022
Yogbot-13
added a commit
that referenced
this pull request
May 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Bloodbrothers are one of the weakest antagonists. They're also the only syndicate antagonist to have NO syndicate equipment. By giving them access to the items from 'makeshift weapons' they can have more room to improvise, which is what they're meant to do anyways.
Wiki Documentation
Probably put a blurb about them having the makeshift weapons recipes on the bloodbrother page.
Changelog
🆑
rscadd: Blood brothers will now start with all of the makeshift weapons recipes learned.
/:cl:
Closes:#13954