chore: ESLint から Biome へ一元化(#45)#70
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (13)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (12)
📝 WalkthroughSummary by CodeRabbit
WalkthroughESLint 設定を廃止し、Biome による lint/format に移行するための変更です。CLAUDE.md と TODO.md を更新し、src と tests 配下の複数ファイルで import 順序やコード整形を行っています。ロジックや公開インターフェースの変更はありません。 ChangesBiome 移行
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 72.55% 72.18% -0.38%
==========================================
Files 13 13
Lines 266 266
Branches 67 68 +1
==========================================
- Hits 193 192 -1
- Misses 64 65 +1
Partials 9 9
🚀 New features to boost your workflow:
|
lint + format を Biome(Rust 単一ツール)に統合し、欠けていたフォーマッタを
導入。現行 ESLint は type-aware 未使用の軽量構成だったため移行コストは小さい。
- biome.json(新規): recommended + noExplicitAny=error、既存 style に合わせ
space/2/lineWidth 100/single-quote、useIgnoreFile で dist/coverage 除外
- package.json: lint を biome check に、format を追加、lint:fix を biome に。
eslint / @eslint/js / typescript-eslint を devDependencies から削除
- eslint.config.mjs を削除
- CLAUDE.md: Commands を biome に更新
- src/tests: biome で一度フォーマット + import 整理(差分は整形のみ)
- main.ts: ユーザーに見せる `${{ github.token }}` リテラルに
noTemplateCurlyInString の biome-ignore(false positive)
- TODO.md: #45 を解決済み(#69)へ
pnpm run all(typecheck + biome check + 95 tests + build)green を確認。
ci.yml は `pnpm run lint` を呼ぶだけなので変更不要。
Closes #45
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AECzAv2vcdATecuvLjBSa6
|
@coderabbitai review |
✅ Action performedReview finished.
|
概要
#45 の評価結果として Biome 一元化を採用。lint + format を Biome(Rust 単一ツール)に統合し、欠けていたフォーマッタを導入する。現行 ESLint は
typescript-eslintの recommended(type-aware 未使用)+no-explicit-anyのみという軽量構成だったため、移行で失うルールが少なく低コスト。変更内容
biome.json(新規):preset: recommended+noExplicitAny: error。既存 style に合わせindentStyle: space/indentWidth: 2/lineWidth: 100/quoteStyle: single。useIgnoreFile+!dist/!coverageで除外。organizeImports有効package.json:lintをbiome check .に、format(biome format --write)を追加、lint:fixをbiome check --writeに。eslint/@eslint/js/typescript-eslintを devDependencies から削除eslint.config.mjsを削除CLAUDE.md: Commands を Biome に更新src/main.ts: ユーザーに提示する${{ github.token }}リテラルにnoTemplateCurlyInStringのbiome-ignore(false positive を個別抑制)TODO.md: [chore] Biome 導入を評価 #45 を解決済みへ検証
pnpm run all(typecheck + biome check + 95 tests + build)greenci.ymlはpnpm run lintを呼ぶだけなので変更不要(CI で biome が走る)参照
🤖 Generated with Claude Code
Summary by cubic
Switch the repo from ESLint to Biome to unify linting and formatting. Style is preserved with no runtime changes; CI still runs
pnpm run lint(now Biome).Refactors
biome.json(recommended preset,noExplicitAny=error, 2-space indent, width 100, single quotes, ignoresdist/coverage, organizes imports).lint->biome check ., addformat(biome format --write .),lint:fix->biome check --write; docs updated (CLAUDE.md).src/testsand organize imports only; no logic changes.// biome-ignorefornoTemplateCurlyInStringon the literal${{ github.token }}message.eslint.config.mjs; mark [chore] Biome 導入を評価 #45 resolved inTODO.md.Dependencies
@biomejs/biome@2.5.2(pinned).eslint,@eslint/js,typescript-eslint.Written for commit dc19078. Summary will update on new commits.